Add custom text input widget with cursor, to use in search page #329
+151
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aome510
approved these changes
Jan 16, 2024
There was a problem hiding this comment.
Thank you for the PR. Look great!
Sorry for the late review, I can only have a chance to look into it after my vacation. I also push a small commit to cleanup a few things.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found using the search bar to be a confusing experience without a cursor. This adds a very simple implementation. You can type, delete with backspace, and navigate with left/right arrows. This can be easily extended in the future to support some basic Emacs-style navigation: by word, end of line etc.
Short video containing usage:
https://github.com/aome510/spotify-player/assets/12721457/5a342c28-d447-4696-ac48-e3d4f0b283bc