Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix memory leak issue when rendering images in iTerm2 #319

Merged
merged 3 commits into from
Dec 11, 2023
Merged

Fix memory leak issue when rendering images in iTerm2 #319

merged 3 commits into from
Dec 11, 2023

Conversation

aome510
Copy link
Owner

@aome510 aome510 commented Dec 11, 2023 •
edited
Loading

Resolves #318

Changes

  • remove cover_image_refresh_duration_in_ms config option
  • update image rendering logic to only trigger when the state changes (previously render periodically)

@aome510 aome510 changed the title Fix memory leak issue when rendering images in ITerm2 Fix memory leak issue when rendering images in iTerm2 Dec 11, 2023
@aome510 aome510 mentioned this pull request Dec 11, 2023
Closed
@diegoulloao
Copy link

diegoulloao commented Dec 11, 2023 •
edited
Loading

@aome510 is working good at my end! 👌🏻 after 15-20 minutes of playing memory haven't increased, just using around 320-370MB all the time.

Screenshot 8

Speed is higher from my POV. Not sure if the image thing have direct impact on it.

@aome510 aome510 merged commit cb0ca36 into master Dec 11, 2023
3 checks passed
@aome510 aome510 deleted the fix-memleak-with-image branch December 11, 2023 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Leak of memory on iTerm2 after long period of usage
2 participants
@aome510 @diegoulloao