-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI album year #305
UI album year #305
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. I don't think it needs a config option as the release year should be included when displaying albums in the artist page.
Change comment Co-authored-by: Thang Pham <phamducthang1234@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks. Can you also fix the CI failed?
Thanks for fixing the formatting & merging this change. |
Thanks for developing spotify-player. I enjoy using it a lot. One thing that was nagging me was that the interface did not give me a sense of time when browsing an artist's page. I therefore added a config option to display the album names prefixed with the year.
As there was no issue mentioning this, I don't know if this implementation fits your ideas for spotify-player, just let me know if it doesn't. Also, my Rust is a bit rusty, so let me know if you have some suggestions before merging this.