[SOL] Fix bug in LLD that prevented linker from being called twice #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lucas Steuernagel <lucas.tnagel@gmail.com>
|
Could you please make this PR on solana-rustc/15.0-2022-08-09 branch https://github.com/solana-labs/llvm-project/tree/solana-rustc/15.0-2022-08-09 ? We'll switch to the new branch soon, when solana monorepo is bumped to new version of sbf-tools solana-labs/solana#29325 |
We'd like to switch to llvm 15 but we depend on inkwell which does not support 15 yet (hopefully soon). So, for now we would like to move to llvm 14 and once inkwell supports 15 we can move too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After moving Solang to LLVM 14, an assertion in the linker was failing when we would call it more than once. This PR from the official repository introduced a new data structure
LinkerContextto manage the error handler and the early exit, but it did not call thecleanUpCallBackwhen we are not exiting the linker early. This PR fixes this bug, so that we can use LLVM 14 on Solang.