refactor: consolidate simple transaction validations to instruction_details sanitization #4525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tao-stones
force-pushed
the
refactor-consolidates-validation-at-instruction-details-sanitization
branch
from
d788b23 to
51954ba
Compare
…tails to better reflect its purpose
tao-stones
force-pushed
the
refactor-consolidates-validation-at-instruction-details-sanitization
branch
from
51954ba to
35e902b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
banking_stage (for both legacy and central scheduler) filters out transactions that have insufficient CU limit, or have excessive precompiles. Each check takes an additional iteration of instructions. These filtering/validations can be done once during RuntimeTransaction sanitizing instruction details, could yield positive performance impact.
Summary of Changes
Fixes #