simplifies blockstore Column::index implementations #4464
+71
−64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
behzadnouri
force-pushed
the
bs-convert-key-slices
branch
2 times, most recently
from
573ff81 to
d194fb4
Compare
behzadnouri
force-pushed
the
bs-convert-key-slices
branch
from
d194fb4 to
ab550f8
Compare
steviez
reviewed
Jan 17, 2025
behzadnouri
force-pushed
the
bs-convert-key-slices
branch
from
ab550f8 to
7e2209b
Compare
|
CI was broken in master from the version bump on Rust; Brennan just pushed a fix with #4526 so think you'll need to rebase to current tip to of master to get all greens for CI |
The commits adds a small macro to simplify
pub trait Column {
fn index(key: &[u8]) -> Self::Index;
// ...
}
implementations.
behzadnouri
force-pushed
the
bs-convert-key-slices
branch
from
626aea4 to
3daf3d7
Compare
done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Column::indeximplementations are verbose and not very readable.Summary of Changes
Implemented a macro to simplify the code.