make solana-metrics optional in vote and stake programs #4425
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
LiteSVM depends on these crates, and their dependency on solana-metrics harms compile times and portability significantly. The vote program uses metrics directly, while the stake program merely depends on solana-metrics crate via its solana-vote-program dependency.
Summary of Changes
default-features = false
to the workspace Cargo.toml entries for the vote and stake programs. This is required to allow people to disable default features. This does not actually disable default features for other workspace dependents unless they each individually disable default features. More info here: https://doc.rust-lang.org/edition-guide/rust-2024/cargo-inherited-default-features.html