Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uses lazy LRU cache for ReedSolomonCache #4367

Merged

Conversation

behzadnouri
Copy link

Problem

Lazy LRU is generally faster and allows immutable shared access on the read path.

Summary of Changes

  • The commit uses lazy LRU cache for ReedSolomonCache.
  • This also allows to use shared-locks on the read path.

Lazy LRU is generally faster and allows immutable shared access on the
read path.
@behzadnouri behzadnouri requested a review from gregcusack January 9, 2025 21:23
Copy link

@alexpyattaev alexpyattaev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like lazy_lru is also quite a bit simpler inside (as well as not requiring exclusive locking). Lgtm. It may be a good idea to migrate to it for all use-cases.

@behzadnouri behzadnouri merged commit 0f616a1 into anza-xyz:master Jan 13, 2025
40 checks passed
@behzadnouri behzadnouri deleted the lazy-lru-reed-solomon-cache branch January 13, 2025 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants