forked from solana-labs/solana
-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simd 118: extend EpochRewards sysvar #428
Merged
CriesofCarrots
merged 8 commits into
anza-xyz:master
from
CriesofCarrots:simd-118-sysvar
Mar 28, 2024
Merged
Simd 118: extend EpochRewards sysvar #428
CriesofCarrots
merged 8 commits into
anza-xyz:master
from
CriesofCarrots:simd-118-sysvar
Mar 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CriesofCarrots
force-pushed
the
simd-118-sysvar
branch
from
March 26, 2024 19:08
7e01feb
to
eee0c74
Compare
joncinque
previously approved these changes
Mar 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Just the the nit for the docs code
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #428 +/- ##
=========================================
- Coverage 81.9% 81.8% -0.1%
=========================================
Files 840 841 +1
Lines 228107 228284 +177
=========================================
+ Hits 186851 186940 +89
- Misses 41256 41344 +88 |
joncinque
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The new design for partitioned epoch rewards requires more data stored in the
EpochRewards
sysvar.Summary of Changes
Update the sysvar: add new fields, specify the alignment, and update clone trait
This PR does not change any rewards calculation or distribution behavior. When
enable_partitioned_epoch_reward
feature gate is active, the sysvar is still populated during rewards calculation and destroyed at the end of distribution.It turns out the
distribution_complete_block_height
field (which I removed) wasn't being used for anything...