Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SchedulerController: receive_completed before scheduling #4229

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

apfitzge
Copy link

@apfitzge apfitzge commented Jan 1, 2025

Problem

  • receive_completed is called immediately after scheduling...when it is very likely nothing (that was just scheduled) has completed.
  • It is better to to call receive_completed sometime after the (potentially) long call to receive_and_buffer and before the next schedule.

Summary of Changes

Flip-flop the lines so that we receive_completed before scheduling (after receive_and_buffer)

Fixes #

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant