Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cli: fix inflation rewards effective slot, block time #4226

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

CriesofCarrots
Copy link

Problem

As of partitioned epoch rewards activation, the effective slots and block times returned from solana inflation reward that are incorrect, since the cli assumes that all rewards have been delivered in the same slot.

Summary of Changes

  • Remove general effective slot and block time from human-readable output
  • Deprecate these fields in CliEpochRewardsMetadata and populate with 0 for json output
  • Add verbose display that includes effective slot and blocktime for every reward
  • Query for correct block time for all reward slots

Fixes #3984

Comment on lines +134 to +145
effective_slot: 0, // Deprecated
block_time: 0, // Deprecated
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Open to suggestions for other/better ways to do this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cli: inflation rewards Reward Slot no longer accurate for multiple accounts
1 participant