Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable solana-metrics dependency for wasm target #4216

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dougEfresh
Copy link

Problem

I'm trying to use solana-account-decoder crate in wasm32 target. However, gethostname crate gets pulled in due to dependency on solana-metrics in solana-program-runtime

gethostname v0.2.3
└── solana-metrics v2.1.7
    └── solana-program-runtime v2.1.7
        └── solana-config-program v2.1.7
            └── solana-account-decoder v2.1.7

Summary of Changes

Use build cfg to remove solana-metrics from program-runtime

@ifiokjr FYI

@dougEfresh dougEfresh requested a review from a team as a code owner December 27, 2024 18:43
@LucasSte LucasSte added the CI Pull Request is ready to enter CI label Dec 30, 2024
@anza-team anza-team removed the CI Pull Request is ready to enter CI label Dec 30, 2024
@kevinheavey
Copy link

I have a PR open to make metrics optional in program-runtime #3477

@dougEfresh dougEfresh force-pushed the optional-solana-metrics branch from b1d5fa9 to 4bf82b4 Compare December 31, 2024 15:59
@dougEfresh dougEfresh force-pushed the optional-solana-metrics branch from 4bf82b4 to ecae54f Compare December 31, 2024 16:06
@LucasSte
Copy link

LucasSte commented Jan 2, 2025

@dougEfresh I believe @kevinheavey's PR is nicer since it allows anyone to disable metrics. Does it solve your needs as well? I'm learning towards merging that one instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants