Reduce usage of solana-sdk in accounts-db #4180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinheavey
force-pushed
the
accounts-db-rm-sdk
branch
from
702a8f5 to
ef2abb7
Compare
brooksprumo
approved these changes
Jan 2, 2025
Comment on lines
+5470
to
+5471
| solana_pubkey::Pubkey::from([0; 32]), | ||
| solana_pubkey::Pubkey::from([255; 32]), |
There was a problem hiding this comment.
Could these use Pubkey directly instead?
Suggested change
| solana_pubkey::Pubkey::from([0; 32]), | |
| solana_pubkey::Pubkey::from([255; 32]), | |
| Pubkey::from([0; 32]), | |
| Pubkey::from([255; 32]), |
kevinheavey
added
the
automerge
kevinheavey
added a commit
to kevinheavey/agave
that referenced
this pull request
Jan 3, 2025
* replace all usage of solana_sdk::pubkey::new_rand * replace usage of solana_sdk::hash::Hash * replace usage of solana_sdk::clock::Slot * replace usage of solana_sdk::pubkey
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Most of the solana-sdk usage in accounts-db can be replaced.
Summary of Changes
Replace some of it. There's a lot to replace and this PR is big enough already