Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: change invalid link #4158

Merged
merged 7 commits into from
Jan 6, 2025
Merged

docs: change invalid link #4158

merged 7 commits into from
Jan 6, 2025

Conversation

osrm
Copy link

@osrm osrm commented Dec 18, 2024

Problem

  1. https://github.com/anza-xyz/agave/blob/11b2e3241cc290fb044dbc0629130610232b8571/docs/src/implemented-proposals/staking-rewards.md?plain=1#L27C98-L27C157

External link video for Turbine won't play. ("https://www.youtube.com/watch?v=qt_gDRXHrHQ&t=1s") It's private

2.

View the [metrics dashboard](https://metrics.solana.com:3000/d/monitor/cluster-telemetry) for more

"metrics dashboard" link is invalid.

Summary of Changes

  1. Instead, Replaced to the Turbine Block Propagation link in the anza docs. ("https://docs.anza.xyz/consensus/turbine-block-propagation")

  2. Changed to "metrics dashboard" link.

Fixes #

osrm added 3 commits September 3, 2024 16:43
"seperately" -> "separately"
The link [turbine](https://www.youtube.com/watch?v=qt_gDRXHrHQ&t=1s) is not appropriate because it is a private video. 

Therefore, it seems appropriate to substitute [turbine](https://docs.anza.xyz/consensus/turbine-block-propagation) for the video link.
@mergify mergify bot requested a review from a team December 18, 2024 04:10
Copy link

@CriesofCarrots CriesofCarrots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@CriesofCarrots
Copy link

Docs change only; merging without full CI

@CriesofCarrots CriesofCarrots merged commit 34e5646 into anza-xyz:master Jan 6, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants