rpc-sts: add config options for stake-weighted qos #197
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #197 +/- ##
=========================================
- Coverage 81.9% 81.9% -0.1%
=========================================
Files 837 837
Lines 226898 226912 +14
=========================================
- Hits 185871 185862 -9
- Misses 41027 41050 +23 |
|
Is this ready for review? |
sure! i was trying to think of an easy way to test it. probably gonna have to hijack devnet or something 🤕 |
| @@ -115,6 +115,8 @@ pub struct Config { | |||
| pub batch_send_rate_ms: u64, | |||
| /// When the retry pool exceeds this max size, new transactions are dropped after their first broadcast attempt | |||
| pub retry_pool_max_size: usize, | |||
| pub tpu_peers: Option<Vec<SocketAddr>>, | |||
There was a problem hiding this comment.
What's the value of an Option here, instead of just a Vec that may be empty (when flag isn't set)?
There was a problem hiding this comment.
pedantry mostly. preference for type safety over implicit sentinels
t-nelson
force-pushed
the
stslo
branch
2 times, most recently
from
04c1579 to
fae62c8
Compare
| let mut addresses = config | ||
| .tpu_peers | ||
| .as_ref() | ||
| .map(|addrs| addrs.iter().map(|a| (a, 0)).collect::<Vec<_>>()) |
There was a problem hiding this comment.
This line would be so much simpler and easier to read if tpu_peers was just a Vec.
There was a problem hiding this comment.
it would also be easier to read if we didn't collect the leader id with the leader slot just for the sake of a debug-level log message :upside:
i started to remove it but refrained for the sake of staying on topic
|
v1.18 backport? |
prolly 1.17 too |
|
Backports to the stable branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. |
|
Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis. |
* rpc-sts: plumb options for swqos config * rpc-sts: send to specific tpu peers when configured (cherry picked from commit f41fb84) # Conflicts: # send-transaction-service/src/send_transaction_service.rs # validator/src/cli.rs # validator/src/main.rs
* rpc-sts: plumb options for swqos config * rpc-sts: send to specific tpu peers when configured (cherry picked from commit f41fb84) # Conflicts: # send-transaction-service/src/send_transaction_service.rs # validator/src/cli.rs # validator/src/main.rs
* rpc-sts: plumb options for swqos config * rpc-sts: send to specific tpu peers when configured (cherry picked from commit f41fb84) # Conflicts: # send-transaction-service/src/send_transaction_service.rs # validator/src/cli.rs # validator/src/main.rs
* rpc-sts: plumb options for swqos config * rpc-sts: send to specific tpu peers when configured (cherry picked from commit f41fb84) # Conflicts: # send-transaction-service/src/send_transaction_service.rs # validator/src/cli.rs # validator/src/main.rs
…#197) (#340) rpc-sts: add config options for stake-weighted qos (#197) * rpc-sts: plumb options for swqos config * rpc-sts: send to specific tpu peers when configured (cherry picked from commit f41fb84) # Conflicts: # send-transaction-service/src/send_transaction_service.rs # validator/src/cli.rs # validator/src/main.rs Co-authored-by: Trent Nelson <490004+t-nelson@users.noreply.github.com>
…#197) (#341) rpc-sts: add config options for stake-weighted qos (#197) * rpc-sts: plumb options for swqos config * rpc-sts: send to specific tpu peers when configured (cherry picked from commit f41fb84) # Conflicts: # send-transaction-service/src/send_transaction_service.rs # validator/src/cli.rs # validator/src/main.rs Co-authored-by: Trent Nelson <490004+t-nelson@users.noreply.github.com>
…anza-xyz#197) (anza-xyz#341) rpc-sts: add config options for stake-weighted qos (anza-xyz#197) * rpc-sts: plumb options for swqos config * rpc-sts: send to specific tpu peers when configured (cherry picked from commit f41fb84) # Conflicts: # send-transaction-service/src/send_transaction_service.rs # validator/src/cli.rs # validator/src/main.rs Co-authored-by: Trent Nelson <490004+t-nelson@users.noreply.github.com>
* rpc-sts: plumb options for swqos config * rpc-sts: send to specific tpu peers when configured
Problem
no simple way to configure an rpc node to send transactions to staked peer(s), as per stake-weighted qos
Summary of Changes
--rpc-send-transaction-tpu-peer HOST:PORTto specify a specific tpu peer to send transctions to, instead of the current leader. this argument may be passed multiple times.--rpc-send-transaction-also-leaderto continue sending to the current leader even though tpu peers have been specified with--rpc-send-transaction-tpu-peer HOST:PORT