Build ReplicaTransactionInfoV2 using signature from transaction param…

…eter
anza-xyz · Jun 1, 2024 · ae71ffa · ae71ffa
1 parent 8de089a
commit ae71ffa
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 13 deletions.
diff --git a/geyser-plugin-manager/src/transaction_notifier.rs b/geyser-plugin-manager/src/transaction_notifier.rs
@@ -26,17 +26,12 @@ impl TransactionNotifier for TransactionNotifierImpl {
         &self,
         slot: Slot,
         index: usize,
-        signature: &Signature,
         transaction_status_meta: &TransactionStatusMeta,
         transaction: &SanitizedTransaction,
     ) {
         let mut measure = Measure::start("geyser-plugin-notify_plugins_of_transaction_info");
-        let transaction_log_info = Self::build_replica_transaction_info(
-            index,
-            signature,
-            transaction_status_meta,
-            transaction,
-        );
+        let transaction_log_info =
+            Self::build_replica_transaction_info(index, transaction_status_meta, transaction);
 
         let plugin_manager = self.plugin_manager.read().unwrap();
 
@@ -84,13 +79,12 @@ impl TransactionNotifierImpl {
 
     fn build_replica_transaction_info<'a>(
         index: usize,
-        signature: &'a Signature,
         transaction_status_meta: &'a TransactionStatusMeta,
         transaction: &'a SanitizedTransaction,
     ) -> ReplicaTransactionInfoV2<'a> {
         ReplicaTransactionInfoV2 {
             index,
-            signature,
+            signature: transaction.signature(),
             is_vote: transaction.is_simple_vote_transaction(),
             transaction,
             transaction_status_meta,

diff --git a/rpc/src/transaction_notifier_interface.rs b/rpc/src/transaction_notifier_interface.rs
@@ -9,7 +9,6 @@ pub trait TransactionNotifier {
         &self,
         slot: Slot,
         transaction_slot_index: usize,
-        signature: &Signature,
         transaction_status_meta: &TransactionStatusMeta,
         transaction: &SanitizedTransaction,
     );

diff --git a/rpc/src/transaction_status_service.rs b/rpc/src/transaction_status_service.rs
@@ -145,7 +145,6 @@ impl TransactionStatusService {
                             transaction_notifier.notify_transaction(
                                 slot,
                                 transaction_index,
-                                transaction.signature(),
                                 &transaction_status_meta,
                                 &transaction,
                             );
@@ -261,15 +260,14 @@ pub(crate) mod tests {
             &self,
             slot: Slot,
             transaction_index: usize,
-            signature: &Signature,
             transaction_status_meta: &TransactionStatusMeta,
             transaction: &SanitizedTransaction,
         ) {
             self.notifications.insert(
                 TestNotifierKey {
                     slot,
                     transaction_index,
-                    signature: *signature,
+                    signature: *transaction.signature(),
                 },
                 TestNotification {
                     _meta: transaction_status_meta.clone(),