Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upd: README and Variables - general cleanup #56

Merged
merged 2 commits into from
Jan 27, 2025

Conversation

brent-anyscale
Copy link
Collaborator

On branch brent/upd-root-readme
Changes to be committed:
modified: CHANGELOG.md
modified: README.md
modified: variables.tf

Pull request checklist

Please check if your PR fulfills the following requirements:

  • pre-commit has been run
  • Tests for the changes have been added (for bug fixes / features)
  • All tests passing
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Pull Request Type

  • Bugfix
  • New feature
  • Refactoring (no functional changes)
  • Documentation change
  • Other (please describe):

Does this introduce a breaking change?

  • Yes
  • No

On branch brent/upd-root-readme
Changes to be committed:
	modified:   CHANGELOG.md
	modified:   README.md
	modified:   variables.tf
@brent-anyscale brent-anyscale requested a review from a team as a code owner January 27, 2025 23:26
@github-actions github-actions bot added documentation Improvements or additions to documentation terraform labels Jan 27, 2025
Removing hcl references as these aren't rendered correctly in the README

Changes to be committed:
	modified:   README.md
	modified:   variables.tf
Copy link
Member

@hongchaodeng hongchaodeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hongchaodeng hongchaodeng merged commit ab01c14 into main Jan 27, 2025
4 checks passed
@hongchaodeng hongchaodeng deleted the brent/upd-root-readme branch January 27, 2025 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation terraform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants