GO-4594: text gets deleted constantly when I'm typing #1929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
AnastasiaShemyakinskaya
commented
Dec 10, 2024
AnastasiaShemyakinskaya
commented
- IsActive и IsFullDetailsSent returns slices now
- IsFullDetailSent is not overwrite if it's already set for subscription
- sFullDetailSent is set during subscriptions init (for sorted and simple sub)
Signed-off-by: AnastasiaShemyakinskaya <shem98a@mail.ru>
Signed-off-by: AnastasiaShemyakinskaya <shem98a@mail.ru>
deff7
reviewed
Dec 10, 2024
util/maputils/map.go
Outdated
| @@ -0,0 +1,9 @@ | |||
| package maputils | |||
There was a problem hiding this comment.
you can use https://pkg.go.dev/maps
Signed-off-by: AnastasiaShemyakinskaya <shem98a@mail.ru>
Coverage provided by https://github.com/seriousben/go-patch-cover-action |
requilence
requested changes
Dec 10, 2024
core/subscription/cache.go
Outdated
| } | ||
| } else { | ||
| return false | ||
| // GetActive indicates that entry is inside the current pagination window for all of provided subscription IDs |
core/subscription/cache.go
Outdated
| } | ||
| } else { | ||
| return false | ||
| // GetFullDetailsSent that in the context of ALL provided subscriptions we have previously sent the full ObjectSetDetails event |
core/subscription/context.go
Outdated
|
|
||
| notActive := slice.Difference(info.subIds, active) | ||
| detailsNotSent := slice.Difference(info.subIds, detailsSent) | ||
| sentSetDetails = lo.Union(notActive, detailsNotSent) |
There was a problem hiding this comment.
naming("sent") is confusing here, it is actually opposite. Maybe smth like "subIdsToSendFullDetails", "subIdsToSendDiffDetails"
core/subscription/context.go
Outdated
| return msgs | ||
| } | ||
|
|
||
| func (ctx *opCtx) addDetailsSentEvent(msgs []*pb.EventMessage, curr *entry, subIds, keys []string) []*pb.EventMessage { |
There was a problem hiding this comment.
incorrect method naming
| e.subIsActive[pos] = isActive | ||
| e.subFullDetailsSent[pos] = isFullDetailSent | ||
| e.subIsActive[subId] = isActive | ||
| if !e.subFullDetailsSent[subId] { |
There was a problem hiding this comment.
lets add an explaining comment here, why don't we overwrite
Signed-off-by: AnastasiaShemyakinskaya <shem98a@mail.ru>
requilence
approved these changes
Dec 10, 2024
AnastasiaShemyakinskaya
deleted the
go-4594-text-gets-deleted-constantly-when-im-typing
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.