Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GO-4653: Simplify analytics id logic and add more verbose errors #1914

Merged
merged 9 commits into from
Dec 7, 2024

Conversation

mcrakhman
Copy link
Contributor


  • I understand that contributing to this repository will require me to agree with the CLA

Description

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

  • 📜 README.md
  • 📓 tech-docs
  • 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

Copy link

github-actions bot commented Dec 5, 2024

Previous Coverage 50.3% of statements
New Coverage 50.3% of statements
Patch Coverage 58.3% of changed statements (28/48)

Coverage provided by https://github.com/seriousben/go-patch-cover-action

@requilence requilence self-requested a review December 7, 2024 00:32
@requilence requilence merged commit 000ee08 into main Dec 7, 2024
5 checks passed
@requilence requilence deleted the GO-4653-account-object-not-exists-logs branch December 7, 2024 00:41
@github-actions github-actions bot locked and limited conversation to collaborators Dec 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants