Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GO-4472 Improve prefix search #1889

Merged
merged 4 commits into from
Dec 6, 2024
Merged

Conversation

fat-fellow
Copy link
Contributor


  • I understand that contributing to this repository will require me to agree with the CLA

Description

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

  • 📜 README.md
  • 📓 tech-docs
  • 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

@fat-fellow fat-fellow force-pushed the go-4472-improve-prefix-search branch from c673cb9 to 771cbf7 Compare December 5, 2024 19:47
@fat-fellow fat-fellow marked this pull request as ready for review December 6, 2024 11:36
Copy link

github-actions bot commented Dec 6, 2024

Previous Coverage 50.3% of statements
New Coverage 50.3% of statements
Patch Coverage 89.3% of changed statements (25/28)

Coverage provided by https://github.com/seriousben/go-patch-cover-action

@@ -432,6 +456,15 @@ func (f *ftSearchTantivy) Search(spaceIds []string, query string) (results []*Do
)
}

func containsChineseCharacters(s string) bool {
for _, r := range s {
if unicode.Is(unicode.Han, r) { // Проверка на принадлежность к диапазону Han
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Russian

@fat-fellow fat-fellow merged commit 8f635d0 into main Dec 6, 2024
5 checks passed
@fat-fellow fat-fellow deleted the go-4472-improve-prefix-search branch December 6, 2024 14:54
@github-actions github-actions bot locked and limited conversation to collaborators Dec 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants