GO-3358: Fix file migration: add to sync queue #1176
Conversation
WalkthroughThe recent updates focus on enhancing file migration processes within a software system. Modifications include improved synchronization in migration functions, expanded testing for file handling and synchronization, and increased storage capacity in service testing. These changes aim to bolster reliability and efficiency in handling file migrations and uploads. Changes
Recent Review DetailsConfiguration used: CodeRabbit UI Files selected for processing (3)
Additional comments not posted (3)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
| fullFileId := domain.FullFileId{SpaceId: space.Id(), FileId: req.FileId} | ||
| err = s.indexer.addToQueue(ctx, domain.FullID{SpaceID: space.Id(), ObjectID: id}, fullFileId) | ||
| if err != nil { | ||
| // Will be retried in background, so don't return error | ||
| log.Errorf("add to index queue: %v", err) | ||
| err = nil | ||
| } | ||
| return err | ||
|
|
||
| err = s.addToSyncQueue(id, fullFileId, false, false) | ||
| if err != nil { | ||
| return fmt.Errorf("add to sync queue: %w", err) | ||
| } | ||
| return nil |
There was a problem hiding this comment.
Consider revising the error handling strategy for adding to the sync queue.
The current implementation suppresses the error from addToSyncQueue by setting err to nil after logging. This could potentially hide issues that might need attention. Consider allowing this error to propagate or ensuring it is handled appropriately elsewhere in the system.
- log.Errorf("add to index queue: %v", err)
- err = nilCommittable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| fullFileId := domain.FullFileId{SpaceId: space.Id(), FileId: req.FileId} | |
| err = s.indexer.addToQueue(ctx, domain.FullID{SpaceID: space.Id(), ObjectID: id}, fullFileId) | |
| if err != nil { | |
| // Will be retried in background, so don't return error | |
| log.Errorf("add to index queue: %v", err) | |
| err = nil | |
| } | |
| return err | |
| err = s.addToSyncQueue(id, fullFileId, false, false) | |
| if err != nil { | |
| return fmt.Errorf("add to sync queue: %w", err) | |
| } | |
| return nil | |
| fullFileId := domain.FullFileId{SpaceId: space.Id(), FileId: req.FileId} | |
| err = s.indexer.addToQueue(ctx, domain.FullID{SpaceID: space.Id(), ObjectID: id}, fullFileId) | |
| if err != nil { | |
| // Will be retried in background, so don't return error | |
| log.Errorf("add to index queue: %v", err) | |
| } | |
| err = s.addToSyncQueue(id, fullFileId, false, false) | |
| if err != nil { | |
| return fmt.Errorf("add to sync queue: %w", err) | |
| } | |
| return nil |
Summary by CodeRabbit