Skip to content

GO-3258 temp disable blocks parent cache #1142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 18, 2024

Conversation

requilence
Copy link
Contributor

@requilence requilence commented Apr 18, 2024

In some cases the cache state is invalid and leads to error when apply changes "target without parent"

Summary by CodeRabbit

  • Refactor
    • Temporarily disabled the parent IDs cache in the editor to enhance testing. Cache will be re-enabled after test coverage is verified.

@requilence requilence requested a review from deff7 April 18, 2024 08:26
Copy link

coderabbitai bot commented Apr 18, 2024

Walkthrough

The adjustment in the State struct of the editor's state management involves a temporary suspension of the cache in the EnableParentIdsCache function, awaiting reactivation post-testing. This alteration centers on inserting a return true statement before verifying the cache's status.

Changes

File Path Change Summary
core/block/editor/state/... Temporary cache suspension in EnableParentIdsCache, added return true before cache check.

Poem

🐇💻🌟
Within the code's dance, a shift takes place,
Pausing the cache with a trace of grace.
"Halt," whispers the rabbit, wise and bright,
Test first, then journey into the night.
🌼🚀🐰


Recent Review Details

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between fd62515 and 9cd86c1.
Files selected for processing (1)
  • core/block/editor/state/state.go (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • core/block/editor/state/state.go

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

github-actions bot commented Apr 18, 2024

New Coverage 44.2% of statements
Patch Coverage 100.0% of changed statements (2/2)

Coverage provided by https://github.com/seriousben/go-patch-cover-action

@requilence requilence requested a review from deff7 April 18, 2024 18:20
@requilence requilence merged commit 37bb273 into main Apr 18, 2024
@requilence requilence deleted the go-3258-disappearing-blocks-desktop-v-03920-beta branch April 18, 2024 19:01
@github-actions github-actions bot locked and limited conversation to collaborators Apr 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants