Skip to content

GO-3294 Fix drop files error #1127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2024
Merged

GO-3294 Fix drop files error #1127

merged 1 commit into from
Apr 16, 2024

Conversation

fat-fellow
Copy link
Contributor

@fat-fellow fat-fellow commented Apr 16, 2024


  • I understand that contributing to this repository will require me to agree with the CLA

Description

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

  • 📜 README.md
  • 📓 tech-docs
  • 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

Summary by CodeRabbit

  • New Features

    • Enhanced file interface to include new configuration settings.
    • Added dropFilesHandler to improve file handling capabilities.
  • Refactor

    • Updated import statements and function usage in test files.
    • Renamed packages and updated function signatures for better file management.
  • Tests

    • Modified test setups to integrate new mock file functionalities.

Copy link

coderabbitai bot commented Apr 16, 2024

Walkthrough

The recent changes introduce enhancements and modifications across the file handling system. A new configuration setting has been added to the .mockery.yaml, improving the File interface. The test environment sees a shift in import practices and usage of mock files, while the File interface itself is expanded with a new handler. Additionally, the mock file handling is upgraded with new methods and dependencies to better manage file operations.

Changes

File Path Change Summary
.mockery.yaml Added new config setting to the File interface including directory, output package, and in-package flag.
core/.../clipboard/clipboard_helpers_test.go Updated imports and modified newFixture function to use new mock file method.
core/.../editor/file/file.go Added dropFilesHandler field to the File interface.
core/.../editor/file/mock_File.go Renovated file handling with new methods, dependencies, and updated function signatures.

🐇 A Whimsical Poem by CodeRabbit 🌟

Oh, hop and tweak, the code does leap,
Across the files, the changes seep.
With each new line, a feature grows,
In digital fields where binary flows.
Mock files dance, and configs align,
In the warren of code, all is divine! 🌼


Recent Review Details

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between e83b367 and d00fff9.
Files selected for processing (4)
  • .mockery.yaml (1 hunks)
  • core/block/editor/clipboard/clipboard_helpers_test.go (2 hunks)
  • core/block/editor/file/file.go (1 hunks)
  • core/block/editor/file/mock_File.go (7 hunks)
Additional comments not posted (8)
.mockery.yaml (1)

26-29: The new configuration settings for the File interface are correctly implemented and formatted.

core/block/editor/clipboard/clipboard_helpers_test.go (2)

12-12: Updated import statements correctly reflect the new package structure.


248-248: Correct usage of file.NewMockFile aligns with the updated package structure.

core/block/editor/file/file.go (1)

60-60: The addition of dropFilesHandler to the File interface is correctly implemented and is essential for handling file drops.

core/block/editor/file/mock_File.go (4)

3-3: Package renaming and adjustments are correctly implemented in the mock file.


8-9: Introduction of new dependencies for file handling is correctly implemented.


12-13: Type adjustments are correctly implemented to align with the changes in the File interface.


350-511: > 📝 NOTE

This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [250-506]

New methods for handling file structure creation, setting file information, and creating uploaders are correctly implemented and necessary for testing.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

New Coverage 43.2% of statements
Patch Coverage 0.0% of changed statements (0/0)

Coverage provided by https://github.com/seriousben/go-patch-cover-action

@fat-fellow fat-fellow merged commit 6727b61 into main Apr 16, 2024
@fat-fellow fat-fellow deleted the go-3294-fix-drop-files-error branch April 16, 2024 18:48
@github-actions github-actions bot locked and limited conversation to collaborators Apr 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants