Skip to content

GO-3284 rename method: Tiers.Get -> GetTiers #1121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 16, 2024
Merged

GO-3284 rename method: Tiers.Get -> GetTiers #1121

merged 3 commits into from
Apr 16, 2024

Conversation

AnthonyAkentiev
Copy link
Contributor

@AnthonyAkentiev AnthonyAkentiev commented Apr 16, 2024


  • I understand that contributing to this repository will require me to agree with the CLA

Description

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

  • 📜 README.md
  • 📓 tech-docs
  • 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

Summary by CodeRabbit

  • New Features
    • Introduced new RPC entities to enhance membership tiers retrieval functionality.
  • Refactor
    • Updated function signatures and RPC message types across multiple files to standardize error handling and response structuring for membership tiers.
  • Tests
    • Adjusted tests to align with updated RPC message types and function signatures related to membership tiers.
  • Documentation
    • Updated documentation to reflect new RPC structures for membership tiers.

Copy link

coderabbitai bot commented Apr 16, 2024

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

Commits Files that changed from the base of the PR and between 67a94e8 and 75d2ae6.
Files ignored due to path filters (1)
  • pb/commands.pb.go is excluded by !**/*.pb.go
Files selected for processing (2)
  • docs/proto.md (9 hunks)
  • pb/protos/commands.proto (1 hunks)
 ___________________
< Look ma, no bugs! >
 -------------------
  \
   \   (\__/)
       (•ㅅ•)
       /   づ

Walkthrough

The changes across various files revamp the handling of membership tiers in the payment system. The updates involve renaming and restructuring data structures, methods, and RPC declarations to enhance error handling and response structuring for tier-related operations.

Changes

Files Summary
core/payments.go, core/payments/payments.go, core/payments/payments_test.go Updated function signatures and structs to use pb.RpcMembershipGetTiersRequest and pb.RpcMembershipGetTiersResponse.
core/payments/cache/cache.go, core/payments/cache/cache_test.go, core/payments/cache/mock_cache/mock_CacheService.go Altered struct fields, method signatures, and function implementations to align with pb.RpcMembershipGetTiersResponse for caching subscription status and tiers.
docs/proto.md, pb/protos/commands.proto, pb/protos/service/service.proto Introduce new entities and adjust message structures to handle membership tiers effectively.
pkg/lib/pb/model/protos/models.proto Updated PaymentMethod enum to replace MethodCard with MethodStripe.

Poem

🐰 "In lines of code, a dance so grand,
🌟 Membership tiers take a stand.
📜 From old to new, the changes flow,
🎉 Errors handled, with grace they show.
🥕 Let's celebrate, with joy in our hearts,
🐾 For progress made, as coding arts!"


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 8

@@ -288,7 +288,7 @@ func TestGetStatus(t *testing.T) {
}).MinTimes(1)

fx.cache.EXPECT().CacheGet().Return(&psgsr, nil, cache.ErrCacheExpired)
fx.cache.EXPECT().CacheSet(mock.AnythingOfType("*pb.RpcMembershipGetStatusResponse"), mock.AnythingOfType("*pb.RpcMembershipTiersGetResponse"), cacheExpireTime).RunAndReturn(func(in *pb.RpcMembershipGetStatusResponse, tiers *pb.RpcMembershipTiersGetResponse, expire time.Time) (err error) {
fx.cache.EXPECT().CacheSet(mock.AnythingOfType("*pb.RpcMembershipGetStatusResponse"), mock.AnythingOfType("*pb.RpcMembershipGetTiersResponse"), cacheExpireTime).RunAndReturn(func(in *pb.RpcMembershipGetStatusResponse, tiers *pb.RpcMembershipGetTiersResponse, expire time.Time) (err error) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review the error handling in CacheSet to ensure that it properly handles scenarios where the cache write fails.

Consider improving error handling by adding specific error messages or recovery mechanisms in case of cache write failures.

Copy link

New Coverage 42.5% of statements
Patch Coverage 20.6% of changed statements (26/126)

Coverage provided by https://github.com/seriousben/go-patch-cover-action

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 8

@@ -1196,7 +1196,7 @@ message Membership {

enum PaymentMethod {
MethodNone = 0;
MethodCard = 1;
MethodStripe = 1;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tip

Codebase Verification

The renaming of MethodCard to MethodStripe in the PaymentMethod enum has been correctly applied in the protobuf files and documentation. However, the term MethodCard is still used in the Go code (payments_test.go and payments.go), which indicates that the renaming has not been fully propagated to all parts of the codebase. It is recommended to update these references to MethodStripe to maintain consistency and prevent potential issues.

Analysis chain

Renamed MethodCard to MethodStripe in the PaymentMethod enum.

Scripts Executed

The following scripts were executed for the analysis:


Script:

#!/bin/bash
# Search for occurrences of 'MethodStripe' and 'MethodCard' to ensure the change is consistently applied.
rg --type proto 'MethodStripe|MethodCard' --files-with-matches

Length of output: 94



Script:

#!/bin/bash
# Search for occurrences of 'MethodStripe' and 'MethodCard' to ensure the change is consistently applied, without specifying file type.
rg 'MethodStripe|MethodCard' --files-with-matches

Length of output: 189



Script:

#!/bin/bash
# Inspect occurrences of 'MethodStripe' and 'MethodCard' in each identified file to understand the context of their usage.
echo "Occurrences in models.pb.go:"
rg 'MethodStripe|MethodCard' pkg/lib/pb/model/models.pb.go

echo "Occurrences in models.proto:"
rg 'MethodStripe|MethodCard' pkg/lib/pb/model/protos/models.proto

echo "Occurrences in proto.md:"
rg 'MethodStripe|MethodCard' docs/proto.md

echo "Occurrences in payments_test.go:"
rg 'MethodStripe|MethodCard' core/payments/payments_test.go

echo "Occurrences in payments.go:"
rg 'MethodStripe|MethodCard' core/payments/payments.go

Length of output: 1115

@AnthonyAkentiev AnthonyAkentiev merged commit 6e898a7 into main Apr 16, 2024
@AnthonyAkentiev AnthonyAkentiev deleted the GO-3284 branch April 16, 2024 14:18
@github-actions github-actions bot locked and limited conversation to collaborators Apr 16, 2024
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 7

Comment on lines +649 to +652
- [Rpc.Membership.GetTiers](#anytype-Rpc-Membership-GetTiers)
- [Rpc.Membership.GetTiers.Request](#anytype-Rpc-Membership-GetTiers-Request)
- [Rpc.Membership.GetTiers.Response](#anytype-Rpc-Membership-GetTiers-Response)
- [Rpc.Membership.GetTiers.Response.Error](#anytype-Rpc-Membership-GetTiers-Response-Error)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adjust the indentation of the unordered list items to match the expected level.

-    - [Rpc.Membership.GetTiers](#anytype-Rpc-Membership-GetTiers)
-    - [Rpc.Membership.GetTiers.Request](#anytype-Rpc-Membership-GetTiers-Request)
-    - [Rpc.Membership.GetTiers.Response](#anytype-Rpc-Membership-GetTiers-Response)
-    - [Rpc.Membership.GetTiers.Response.Error](#anytype-Rpc-Membership-GetTiers-Response-Error)
+  - [Rpc.Membership.GetTiers](#anytype-Rpc-Membership-GetTiers)
+  - [Rpc.Membership.GetTiers.Request](#anytype-Rpc-Membership-GetTiers-Request)
+  - [Rpc.Membership.GetTiers.Response](#anytype-Rpc-Membership-GetTiers-Response)
+  - [Rpc.Membership.GetTiers.Response.Error](#anytype-Rpc-Membership-GetTiers-Response-Error)

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
- [Rpc.Membership.GetTiers](#anytype-Rpc-Membership-GetTiers)
- [Rpc.Membership.GetTiers.Request](#anytype-Rpc-Membership-GetTiers-Request)
- [Rpc.Membership.GetTiers.Response](#anytype-Rpc-Membership-GetTiers-Response)
- [Rpc.Membership.GetTiers.Response.Error](#anytype-Rpc-Membership-GetTiers-Response-Error)
- [Rpc.Membership.GetTiers](#anytype-Rpc-Membership-GetTiers)
- [Rpc.Membership.GetTiers.Request](#anytype-Rpc-Membership-GetTiers-Request)
- [Rpc.Membership.GetTiers.Response](#anytype-Rpc-Membership-GetTiers-Response)
- [Rpc.Membership.GetTiers.Response.Error](#anytype-Rpc-Membership-GetTiers-Response-Error)

Comment on lines 662 to 667
- [Rpc.Membership.IsNameValid.Request](#anytype-Rpc-Membership-IsNameValid-Request)
- [Rpc.Membership.IsNameValid.Response](#anytype-Rpc-Membership-IsNameValid-Response)
- [Rpc.Membership.IsNameValid.Response.Error](#anytype-Rpc-Membership-IsNameValid-Response-Error)
- [Rpc.Membership.Tiers](#anytype-Rpc-Membership-Tiers)
- [Rpc.Membership.Tiers.Get](#anytype-Rpc-Membership-Tiers-Get)
- [Rpc.Membership.Tiers.Get.Request](#anytype-Rpc-Membership-Tiers-Get-Request)
- [Rpc.Membership.Tiers.Get.Response](#anytype-Rpc-Membership-Tiers-Get-Response)
- [Rpc.Membership.Tiers.Get.Response.Error](#anytype-Rpc-Membership-Tiers-Get-Response-Error)
- [Rpc.Membership.VerifyEmailCode](#anytype-Rpc-Membership-VerifyEmailCode)
- [Rpc.Membership.VerifyEmailCode.Request](#anytype-Rpc-Membership-VerifyEmailCode-Request)
- [Rpc.Membership.VerifyEmailCode.Response](#anytype-Rpc-Membership-VerifyEmailCode-Response)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure consistent indentation for list items to improve readability.

-    - [Rpc.Membership.IsNameValid.Request](#anytype-Rpc-Membership-IsNameValid-Request)
-    - [Rpc.Membership.IsNameValid.Response](#anytype-Rpc-Membership-IsNameValid-Response)
-    - [Rpc.Membership.IsNameValid.Response.Error](#anytype-Rpc-Membership-IsNameValid-Response-Error)
-    - [Rpc.Membership.VerifyEmailCode](#anytype-Rpc-Membership-VerifyEmailCode)
-    - [Rpc.Membership.VerifyEmailCode.Request](#anytype-Rpc-Membership-VerifyEmailCode-Request)
-    - [Rpc.Membership.VerifyEmailCode.Response](#anytype-Rpc-Membership-VerifyEmailCode-Response)
+  - [Rpc.Membership.IsNameValid.Request](#anytype-Rpc-Membership-IsNameValid-Request)
+  - [Rpc.Membership.IsNameValid.Response](#anytype-Rpc-Membership-IsNameValid-Response)
+  - [Rpc.Membership.IsNameValid.Response.Error](#anytype-Rpc-Membership-IsNameValid-Response-Error)
+  - [Rpc.Membership.VerifyEmailCode](#anytype-Rpc-Membership-VerifyEmailCode)
+  - [Rpc.Membership.VerifyEmailCode.Request](#anytype-Rpc-Membership-VerifyEmailCode-Request)
+  - [Rpc.Membership.VerifyEmailCode.Response](#anytype-Rpc-Membership-VerifyEmailCode-Response)

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
- [Rpc.Membership.IsNameValid.Request](#anytype-Rpc-Membership-IsNameValid-Request)
- [Rpc.Membership.IsNameValid.Response](#anytype-Rpc-Membership-IsNameValid-Response)
- [Rpc.Membership.IsNameValid.Response.Error](#anytype-Rpc-Membership-IsNameValid-Response-Error)
- [Rpc.Membership.Tiers](#anytype-Rpc-Membership-Tiers)
- [Rpc.Membership.Tiers.Get](#anytype-Rpc-Membership-Tiers-Get)
- [Rpc.Membership.Tiers.Get.Request](#anytype-Rpc-Membership-Tiers-Get-Request)
- [Rpc.Membership.Tiers.Get.Response](#anytype-Rpc-Membership-Tiers-Get-Response)
- [Rpc.Membership.Tiers.Get.Response.Error](#anytype-Rpc-Membership-Tiers-Get-Response-Error)
- [Rpc.Membership.VerifyEmailCode](#anytype-Rpc-Membership-VerifyEmailCode)
- [Rpc.Membership.VerifyEmailCode.Request](#anytype-Rpc-Membership-VerifyEmailCode-Request)
- [Rpc.Membership.VerifyEmailCode.Response](#anytype-Rpc-Membership-VerifyEmailCode-Response)
- [Rpc.Membership.IsNameValid.Request](#anytype-Rpc-Membership-IsNameValid-Request)
- [Rpc.Membership.IsNameValid.Response](#anytype-Rpc-Membership-IsNameValid-Response)
- [Rpc.Membership.IsNameValid.Response.Error](#anytype-Rpc-Membership-IsNameValid-Response-Error)
- [Rpc.Membership.VerifyEmailCode](#anytype-Rpc-Membership-VerifyEmailCode)
- [Rpc.Membership.VerifyEmailCode.Request](#anytype-Rpc-Membership-VerifyEmailCode-Request)
- [Rpc.Membership.VerifyEmailCode.Response](#anytype-Rpc-Membership-VerifyEmailCode-Response)

Comment on lines +1261 to 1267
- [Rpc.Membership.GetTiers.Response.Error.Code](#anytype-Rpc-Membership-GetTiers-Response-Error-Code)
- [Rpc.Membership.GetVerificationEmail.Response.Error.Code](#anytype-Rpc-Membership-GetVerificationEmail-Response-Error-Code)
- [Rpc.Membership.GetVerificationEmailStatus.Response.Error.Code](#anytype-Rpc-Membership-GetVerificationEmailStatus-Response-Error-Code)
- [Rpc.Membership.IsNameValid.Response.Error.Code](#anytype-Rpc-Membership-IsNameValid-Response-Error-Code)
- [Rpc.Membership.Tiers.Get.Response.Error.Code](#anytype-Rpc-Membership-Tiers-Get-Response-Error-Code)
- [Rpc.Membership.VerifyEmailCode.Response.Error.Code](#anytype-Rpc-Membership-VerifyEmailCode-Response-Error-Code)
- [Rpc.Metrics.SetParameters.Response.Error.Code](#anytype-Rpc-Metrics-SetParameters-Response-Error-Code)
- [Rpc.NameService.ResolveAnyId.Response.Error.Code](#anytype-Rpc-NameService-ResolveAnyId-Response-Error-Code)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct the indentation for the list of error codes to align with the rest of the document.

-    - [Rpc.Membership.GetTiers.Response.Error.Code](#anytype-Rpc-Membership-GetTiers-Response-Error-Code)
-    - [Rpc.Membership.GetVerificationEmail.Response.Error.Code](#anytype-Rpc-Membership-GetVerificationEmail-Response-Error-Code)
-    - [Rpc.Membership.GetVerificationEmailStatus.Response.Error.Code](#anytype-Rpc-Membership-GetVerificationEmailStatus-Response-Error-Code)
-    - [Rpc.Membership.IsNameValid.Response.Error.Code](#anytype-Rpc-Membership-IsNameValid-Response-Error-Code)
-    - [Rpc.Membership.VerifyEmailCode.Response.Error.Code](#anytype-Rpc-Membership-VerifyEmailCode-Response-Error-Code)
-    - [Rpc.Metrics.SetParameters.Response.Error.Code](#anytype-Rpc-Metrics-SetParameters-Response-Error-Code)
-    - [Rpc.NameService.ResolveAnyId.Response.Error.Code](#anytype-Rpc-NameService-ResolveAnyId-Response-Error-Code)
+  - [Rpc.Membership.GetTiers.Response.Error.Code](#anytype-Rpc-Membership-GetTiers-Response-Error-Code)
+  - [Rpc.Membership.GetVerificationEmail.Response.Error.Code](#anytype-Rpc-Membership-GetVerificationEmail-Response-Error-Code)
+  - [Rpc.Membership.GetVerificationEmailStatus.Response.Error.Code](#anytype-Rpc-Membership-GetVerificationEmailStatus-Response-Error-Code)
+  - [Rpc.Membership.IsNameValid.Response.Error.Code](#anytype-Rpc-Membership-IsNameValid-Response-Error-Code)
+  - [Rpc.Membership.VerifyEmailCode.Response.Error.Code](#anytype-Rpc-Membership-VerifyEmailCode-Response-Error-Code)
+  - [Rpc.Metrics.SetParameters.Response.Error.Code](#anytype-Rpc-Metrics-SetParameters-Response-Error-Code)
+  - [Rpc.NameService.ResolveAnyId.Response.Error.Code](#anytype-Rpc-NameService-ResolveAnyId-Response-Error-Code)

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
- [Rpc.Membership.GetTiers.Response.Error.Code](#anytype-Rpc-Membership-GetTiers-Response-Error-Code)
- [Rpc.Membership.GetVerificationEmail.Response.Error.Code](#anytype-Rpc-Membership-GetVerificationEmail-Response-Error-Code)
- [Rpc.Membership.GetVerificationEmailStatus.Response.Error.Code](#anytype-Rpc-Membership-GetVerificationEmailStatus-Response-Error-Code)
- [Rpc.Membership.IsNameValid.Response.Error.Code](#anytype-Rpc-Membership-IsNameValid-Response-Error-Code)
- [Rpc.Membership.Tiers.Get.Response.Error.Code](#anytype-Rpc-Membership-Tiers-Get-Response-Error-Code)
- [Rpc.Membership.VerifyEmailCode.Response.Error.Code](#anytype-Rpc-Membership-VerifyEmailCode-Response-Error-Code)
- [Rpc.Metrics.SetParameters.Response.Error.Code](#anytype-Rpc-Metrics-SetParameters-Response-Error-Code)
- [Rpc.NameService.ResolveAnyId.Response.Error.Code](#anytype-Rpc-NameService-ResolveAnyId-Response-Error-Code)
- [Rpc.Membership.GetTiers.Response.Error.Code](#anytype-Rpc-Membership-GetTiers-Response-Error-Code)
- [Rpc.Membership.GetVerificationEmail.Response.Error.Code](#anytype-Rpc-Membership-GetVerificationEmail-Response-Error-Code)
- [Rpc.Membership.GetVerificationEmailStatus.Response.Error.Code](#anytype-Rpc-Membership-GetVerificationEmailStatus-Response-Error-Code)
- [Rpc.Membership.IsNameValid.Response.Error.Code](#anytype-Rpc-Membership-IsNameValid-Response-Error-Code)
- [Rpc.Membership.VerifyEmailCode.Response.Error.Code](#anytype-Rpc-Membership-VerifyEmailCode-Response-Error-Code)
- [Rpc.Metrics.SetParameters.Response.Error.Code](#anytype-Rpc-Metrics-SetParameters-Response-Error-Code)
- [Rpc.NameService.ResolveAnyId.Response.Error.Code](#anytype-Rpc-NameService-ResolveAnyId-Response-Error-Code)

Comment on lines +11342 to +11399
<a name="anytype-Rpc-Membership-GetTiers"></a>

### Rpc.Membership.GetTiers
Tiers can change on the backend so if you want to show users the latest data
you can call this method to get the latest tiers






<a name="anytype-Rpc-Membership-GetTiers-Request"></a>

### Rpc.Membership.GetTiers.Request



| Field | Type | Label | Description |
| ----- | ---- | ----- | ----------- |
| noCache | [bool](#bool) | | pass true to force the cache update by default this is false |
| locale | [string](#string) | | |






<a name="anytype-Rpc-Membership-GetTiers-Response"></a>

### Rpc.Membership.GetTiers.Response



| Field | Type | Label | Description |
| ----- | ---- | ----- | ----------- |
| error | [Rpc.Membership.GetTiers.Response.Error](#anytype-Rpc-Membership-GetTiers-Response-Error) | | |
| tiers | [model.MembershipTierData](#anytype-model-MembershipTierData) | repeated | |






<a name="anytype-Rpc-Membership-GetTiers-Response-Error"></a>

### Rpc.Membership.GetTiers.Response.Error



| Field | Type | Label | Description |
| ----- | ---- | ----- | ----------- |
| code | [Rpc.Membership.GetTiers.Response.Error.Code](#anytype-Rpc-Membership-GetTiers-Response-Error-Code) | | |
| description | [string](#string) | | |





Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please adjust the blank lines around the headings and between sections to improve the document's readability and consistency.

-<a name="anytype-Rpc-Membership-GetTiers"></a>
-
-### Rpc.Membership.GetTiers
-Tiers can change on the backend so if you want to show users the latest data
-you can call this method to get the latest tiers
-
-
-
-
-
-
-
-<a name="anytype-Rpc-Membership-GetTiers-Request"></a>
-
-### Rpc.Membership.GetTiers.Request
-
-
-
-| Field | Type | Label | Description |
-| ----- | ---- | ----- | ----------- |
-| noCache | [bool](#bool) |  | pass true to force the cache update by default this is false |
-| locale | [string](#string) |  |  |
-
-
-
-
-
-
-
-<a name="anytype-Rpc-Membership-GetTiers-Response"></a>
-
-### Rpc.Membership.GetTiers.Response
-
-
-
-| Field | Type | Label | Description |
-| ----- | ---- | ----- | ----------- |
-| error | [Rpc.Membership.GetTiers.Response.Error](#anytype-Rpc-Membership-GetTiers-Response-Error) |  |  |
-| tiers | [model.MembershipTierData](#anytype-model-MembershipTierData) | repeated |  |
-
-
-
-
-
-
-
-<a name="anytype-Rpc-Membership-GetTiers-Response-Error"></a>
-
-### Rpc.Membership.GetTiers.Response.Error
-
-
-
-| Field | Type | Label | Description |
-| ----- | ---- | ----- | ----------- |
-| code | [Rpc.Membership.GetTiers.Response.Error.Code](#anytype-Rpc-Membership-GetTiers-Response-Error-Code) |  |  |
-| description | [string](#string) |  |  |
-
-
-
-
-
-
+<a name="anytype-Rpc-Membership-GetTiers"></a>
+
+### Rpc.Membership.GetTiers
+
+Tiers can change on the backend so if you want to show users the latest data
+you can call this method to get the latest tiers
+
+<a name="anytype-Rpc-Membership-GetTiers-Request"></a>
+
+### Rpc.Membership.GetTiers.Request
+
+| Field | Type | Label | Description |
+| ----- | ---- | ----- | ----------- |
+| noCache | [bool](#bool) |  | pass true to force the cache update by default this is false |
+| locale | [string](#string) |  |  |
+
+<a name="anytype-Rpc-Membership-GetTiers-Response"></a>
+
+### Rpc.Membership.GetTiers.Response
+
+| Field | Type | Label | Description |
+| ----- | ---- | ----- | ----------- |
+| error | [Rpc.Membership.GetTiers.Response.Error](#anytype-Rpc-Membership-GetTiers-Response-Error) |  |  |
+| tiers | [model.MembershipTierData](#anytype-model-MembershipTierData) | repeated |  |
+
+<a name="anytype-Rpc-Membership-GetTiers-Response-Error"></a>
+
+### Rpc.Membership.GetTiers.Response.Error
+
+| Field | Type | Label | Description |
+| ----- | ---- | ----- | ----------- |
+| code | [Rpc.Membership.GetTiers.Response.Error.Code](#anytype-Rpc-Membership-GetTiers-Response-Error-Code) |  |  |
+| description | [string](#string) |  |  |

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
<a name="anytype-Rpc-Membership-GetTiers"></a>
### Rpc.Membership.GetTiers
Tiers can change on the backend so if you want to show users the latest data
you can call this method to get the latest tiers
<a name="anytype-Rpc-Membership-GetTiers-Request"></a>
### Rpc.Membership.GetTiers.Request
| Field | Type | Label | Description |
| ----- | ---- | ----- | ----------- |
| noCache | [bool](#bool) | | pass true to force the cache update by default this is false |
| locale | [string](#string) | | |
<a name="anytype-Rpc-Membership-GetTiers-Response"></a>
### Rpc.Membership.GetTiers.Response
| Field | Type | Label | Description |
| ----- | ---- | ----- | ----------- |
| error | [Rpc.Membership.GetTiers.Response.Error](#anytype-Rpc-Membership-GetTiers-Response-Error) | | |
| tiers | [model.MembershipTierData](#anytype-model-MembershipTierData) | repeated | |
<a name="anytype-Rpc-Membership-GetTiers-Response-Error"></a>
### Rpc.Membership.GetTiers.Response.Error
| Field | Type | Label | Description |
| ----- | ---- | ----- | ----------- |
| code | [Rpc.Membership.GetTiers.Response.Error.Code](#anytype-Rpc-Membership-GetTiers-Response-Error-Code) | | |
| description | [string](#string) | | |
<a name="anytype-Rpc-Membership-GetTiers"></a>
### Rpc.Membership.GetTiers
Tiers can change on the backend so if you want to show users the latest data
you can call this method to get the latest tiers
<a name="anytype-Rpc-Membership-GetTiers-Request"></a>
### Rpc.Membership.GetTiers.Request
| Field | Type | Label | Description |
| ----- | ---- | ----- | ----------- |
| noCache | [bool](#bool) | | pass true to force the cache update by default this is false |
| locale | [string](#string) | | |
<a name="anytype-Rpc-Membership-GetTiers-Response"></a>
### Rpc.Membership.GetTiers.Response
| Field | Type | Label | Description |
| ----- | ---- | ----- | ----------- |
| error | [Rpc.Membership.GetTiers.Response.Error](#anytype-Rpc-Membership-GetTiers-Response-Error) | | |
| tiers | [model.MembershipTierData](#anytype-model-MembershipTierData) | repeated | |
<a name="anytype-Rpc-Membership-GetTiers-Response-Error"></a>
### Rpc.Membership.GetTiers.Response.Error
| Field | Type | Label | Description |
| ----- | ---- | ----- | ----------- |
| code | [Rpc.Membership.GetTiers.Response.Error.Code](#anytype-Rpc-Membership-GetTiers-Response-Error-Code) | | |
| description | [string](#string) | | |

Comment on lines 11568 to 11573



<a name="anytype-Rpc-Membership-Tiers"></a>

### Rpc.Membership.Tiers
Tiers can change on the backend so if you want to show users the latest data
you can call this method to get the latest tiers






<a name="anytype-Rpc-Membership-Tiers-Get"></a>

### Rpc.Membership.Tiers.Get







<a name="anytype-Rpc-Membership-Tiers-Get-Request"></a>

### Rpc.Membership.Tiers.Get.Request



| Field | Type | Label | Description |
| ----- | ---- | ----- | ----------- |
| noCache | [bool](#bool) | | pass true to force the cache update by default this is false |
| locale | [string](#string) | | |






<a name="anytype-Rpc-Membership-Tiers-Get-Response"></a>

### Rpc.Membership.Tiers.Get.Response



| Field | Type | Label | Description |
| ----- | ---- | ----- | ----------- |
| error | [Rpc.Membership.Tiers.Get.Response.Error](#anytype-Rpc-Membership-Tiers-Get-Response-Error) | | |
| tiers | [model.MembershipTierData](#anytype-model-MembershipTierData) | repeated | |






<a name="anytype-Rpc-Membership-Tiers-Get-Response-Error"></a>

### Rpc.Membership.Tiers.Get.Response.Error



| Field | Type | Label | Description |
| ----- | ---- | ----- | ----------- |
| code | [Rpc.Membership.Tiers.Get.Response.Error.Code](#anytype-Rpc-Membership-Tiers-Get-Response-Error-Code) | | |
| description | [string](#string) | | |






<a name="anytype-Rpc-Membership-VerifyEmailCode"></a>

### Rpc.Membership.VerifyEmailCode
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please adjust the blank lines around the VerifyEmailCode heading to maintain consistency with other sections.

-
-
-
-<a name="anytype-Rpc-Membership-VerifyEmailCode"></a>
-
-### Rpc.Membership.VerifyEmailCode
+<a name="anytype-Rpc-Membership-VerifyEmailCode"></a>
+
+### Rpc.Membership.VerifyEmailCode

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
<a name="anytype-Rpc-Membership-Tiers"></a>
### Rpc.Membership.Tiers
Tiers can change on the backend so if you want to show users the latest data
you can call this method to get the latest tiers
<a name="anytype-Rpc-Membership-Tiers-Get"></a>
### Rpc.Membership.Tiers.Get
<a name="anytype-Rpc-Membership-Tiers-Get-Request"></a>
### Rpc.Membership.Tiers.Get.Request
| Field | Type | Label | Description |
| ----- | ---- | ----- | ----------- |
| noCache | [bool](#bool) | | pass true to force the cache update by default this is false |
| locale | [string](#string) | | |
<a name="anytype-Rpc-Membership-Tiers-Get-Response"></a>
### Rpc.Membership.Tiers.Get.Response
| Field | Type | Label | Description |
| ----- | ---- | ----- | ----------- |
| error | [Rpc.Membership.Tiers.Get.Response.Error](#anytype-Rpc-Membership-Tiers-Get-Response-Error) | | |
| tiers | [model.MembershipTierData](#anytype-model-MembershipTierData) | repeated | |
<a name="anytype-Rpc-Membership-Tiers-Get-Response-Error"></a>
### Rpc.Membership.Tiers.Get.Response.Error
| Field | Type | Label | Description |
| ----- | ---- | ----- | ----------- |
| code | [Rpc.Membership.Tiers.Get.Response.Error.Code](#anytype-Rpc-Membership-Tiers-Get-Response-Error-Code) | | |
| description | [string](#string) | | |
<a name="anytype-Rpc-Membership-VerifyEmailCode"></a>
### Rpc.Membership.VerifyEmailCode
<a name="anytype-Rpc-Membership-VerifyEmailCode"></a>
### Rpc.Membership.VerifyEmailCode

Comment on lines +20065 to +20078
<a name="anytype-Rpc-Membership-GetTiers-Response-Error-Code"></a>

### Rpc.Membership.GetTiers.Response.Error.Code


| Name | Number | Description |
| ---- | ------ | ----------- |
| NULL | 0 | |
| UNKNOWN_ERROR | 1 | |
| BAD_INPUT | 2 | |
| NOT_LOGGED_IN | 3 | |
| PAYMENT_NODE_ERROR | 4 | |
| CACHE_ERROR | 5 | |

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reduce the number of blank lines to improve the document structure and readability.

-
-<a name="anytype-Rpc-Membership-GetTiers-Response-Error-Code"></a>
-
-### Rpc.Membership.GetTiers.Response.Error.Code
-
-
-| Name | Number | Description |
-| ---- | ------ | ----------- |
-| NULL | 0 |  |
-| UNKNOWN_ERROR | 1 |  |
-| BAD_INPUT | 2 |  |
-| NOT_LOGGED_IN | 3 |  |
-| PAYMENT_NODE_ERROR | 4 |  |
-| CACHE_ERROR | 5 |  |
-
-
+<a name="anytype-Rpc-Membership-GetTiers-Response-Error-Code"></a>
+
+### Rpc.Membership.GetTiers.Response.Error.Code
+
+| Name | Number | Description |
+| ---- | ------ | ----------- |
+| NULL | 0 |  |
+| UNKNOWN_ERROR | 1 |  |
+| BAD_INPUT | 2 |  |
+| NOT_LOGGED_IN | 3 |  |
+| PAYMENT_NODE_ERROR | 4 |  |
+| CACHE_ERROR | 5 |  |

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
<a name="anytype-Rpc-Membership-GetTiers-Response-Error-Code"></a>
### Rpc.Membership.GetTiers.Response.Error.Code
| Name | Number | Description |
| ---- | ------ | ----------- |
| NULL | 0 | |
| UNKNOWN_ERROR | 1 | |
| BAD_INPUT | 2 | |
| NOT_LOGGED_IN | 3 | |
| PAYMENT_NODE_ERROR | 4 | |
| CACHE_ERROR | 5 | |
<a name="anytype-Rpc-Membership-GetTiers-Response-Error-Code"></a>
### Rpc.Membership.GetTiers.Response.Error.Code
| Name | Number | Description |
| ---- | ------ | ----------- |
| NULL | 0 | |
| UNKNOWN_ERROR | 1 | |
| BAD_INPUT | 2 | |
| NOT_LOGGED_IN | 3 | |
| PAYMENT_NODE_ERROR | 4 | |
| CACHE_ERROR | 5 | |

Comment on lines 20136 to 20137


Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the excessive blank lines to maintain a clean and consistent document structure.

-
-<a name="anytype-Rpc-Membership-VerifyEmailCode-Response-Error-Code"></a>
-
-### Rpc.Membership.VerifyEmailCode.Response.Error.Code
+<a name="anytype-Rpc-Membership-VerifyEmailCode-Response-Error-Code"></a>
+
+### Rpc.Membership.VerifyEmailCode.Response.Error.Code

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
<a name="anytype-Rpc-Membership-VerifyEmailCode-Response-Error-Code"></a>
### Rpc.Membership.VerifyEmailCode.Response.Error.Code

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants