main: Added quit on last client disconnect #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, have you read CONTRIBUTING.md? |
Yes, I did. But obviously not to the very last line. |
any1
reviewed
Jun 2, 2024
|
Thanks for your help. So, I'm going to rename everything to exit-on-disconnect and change 'q' to 'e' accordingly. Will push later today, when I got the time to test it. |
|
LGTM. Please squash into single commit. Keep in mind that commit messages should be written in imperative mood. A commit message should complete the sentence "When applied, this patch will...". I.e. "main: Added quit on last client disconnect" might be written "main: Add option to exit on last disconnect" instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed an option to automatically quit wayvnc when the last client disconnect.
Added a condition in client_destroy() and set self->server->do_exit to true, if condition is met.
For example, if wayvnc will only run intentionally by starting via SSH, it automatically
quit when I close the VNC connection and no other clients are connected.