Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add meson subproject wraps for aml and neatvnc #127

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Consolatis
Copy link
Contributor

@Consolatis Consolatis commented Jan 27, 2022

Makes compiling as easy as:
meson build_dir && meson compile -C build_dir

Makes compiling as easy as:
meson build_dir && meson compile -C build_dir
@eli-schwartz
Copy link

wayvnc/meson.build

Lines 52 to 69 in 3b26a43

neatvnc_project = subproject(
'neatvnc',
required: false,
version: neatvnc_version,
)
aml_project = subproject('aml', required: false)
if aml_project.found()
aml = aml_project.get_variable('aml_dep')
else
aml = dependency('aml')
endif
if neatvnc_project.found()
neatvnc = neatvnc_project.get_variable('neatvnc_dep')
else
neatvnc = dependency('neatvnc', version: neatvnc_version)
endif

The use of subprojects as preferred with fallback to system dependencies means that adding a wrap file actually breaks the ability to build with system deps. This may be the reason that they aren't already wrap files.

I would advise nuking all this code though. See https://mesonbuild.com/Wrap-dependency-system-manual.html#provide-section

dependency('foo') should be enough, and simply use a suitable wrap file that specifies a [provide] section. Meson will natively do subproject fallback, and it can even be configured to prefer subprojects using --wrap-mode=forcefallback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants