Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change error message on mismatched socket and assignment types #153

Merged
merged 1 commit into from
Oct 25, 2022
Merged

change error message on mismatched socket and assignment types #153

merged 1 commit into from
Oct 25, 2022

Conversation

carl-wallace
Copy link
Contributor

Old error assumed socket type was right. New error adds reminder that socket type may be what needs to change.

@anweiss anweiss self-requested a review October 25, 2022 14:03
@anweiss anweiss self-assigned this Oct 25, 2022
@anweiss anweiss added this to the v1.0.0 milestone Oct 25, 2022
anweiss
anweiss approved these changes Oct 25, 2022
View reviewed changes
Copy link
Owner

@anweiss anweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @carl-wallace. Good callout here.

@anweiss anweiss merged commit a57824c into anweiss:main Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anweiss anweiss anweiss approved these changes

Assignees

@anweiss anweiss

Labels
error handling
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@carl-wallace @anweiss