Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a CI general argument to trigger failure when files are not found #144

Merged
merged 2 commits into from
Oct 5, 2022

Conversation

hansl
Copy link
Contributor

@hansl hansl commented Oct 4, 2022

In CI, we had some refactor that moved the files, and CI never failed as the CDDL CLI still returns status 0 when a file is not found.

This addresses it in a backward compatible way by adding a flag that will fail the process (status code 1) if an error happens that would normally not fail (report error in the logs).

@anweiss
Copy link
Owner

anweiss commented Oct 5, 2022

Thanks for this @hansl!

@hansl
Copy link
Contributor Author

hansl commented Oct 5, 2022

@anweiss just fixed CI by running cargo fmt. Should be fine now.

@anweiss anweiss merged commit 9e63e94 into anweiss:main Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants