Skip to content
This repository has been archived by the owner on Feb 25, 2019. It is now read-only.

Enforce client grant_types and response_types #217

Merged
merged 11 commits into from
Sep 3, 2015
Merged

Enforce client grant_types and response_types #217

merged 11 commits into from
Sep 3, 2015

Commits on Sep 3, 2015

  1. feat(Client): Require and provide default for grant_type 

    The OpenID Connect specification makes it clear that this property is optional, and does not need to be specified in order to register a client. However, it provides a desired default value and behaviour.

Marking this property as required in the schema and providing a default value effectively makes it optional, as the default value is used whenever a desired value is not explicitly specified. This falls in line with the defined behaviour in the specification.
    @adalinesimonian
    adalinesimonian committed Sep 3, 2015
    Configuration menu
    Copy the full SHA
    acfe1ee View commit details
    Browse the repository at this point in the history

  2. feat(Client): Require and provide default for response_types 

    The OpenID Connect specification makes it clear that this property is optional, and does not need to be specified in order to register a client. However, it provides a desired default value and behaviour.

Marking this property as required in the schema and providing a default value effectively makes it optional, as the default value is used whenever a desired value is not explicitly specified. This falls in line with the defined behaviour in the specification.
    @adalinesimonian
    adalinesimonian committed Sep 3, 2015
    Configuration menu
    Copy the full SHA
    8136ad6 View commit details
    Browse the repository at this point in the history

  3. feat(Client): Validate response_types against grant_types 

    Validates that clients have the appropriate grant_types defined for their desired response_types per the Client Metadata section in the OpenID Connect Registration 1.0 specification

http://openid.net/specs/openid-connect-registration-1_0.html#ClientMetadata
    @adalinesimonian
    adalinesimonian committed Sep 3, 2015
    Configuration menu
    Copy the full SHA
    9846da6 View commit details
    Browse the repository at this point in the history

  4. fix: Validate response_types regardless of order

    @adalinesimonian
    adalinesimonian committed Sep 3, 2015
    Configuration menu
    Copy the full SHA
    75b6e8d View commit details
    Browse the repository at this point in the history

  5. test(Client): Test response_type validation

    @adalinesimonian
    adalinesimonian committed Sep 3, 2015
    Configuration menu
    Copy the full SHA
    9d4f834 View commit details
    Browse the repository at this point in the history

  6. fix: Trim leading and trailing whitespace in response_type and respon… 

    …se_mode
    @adalinesimonian
    adalinesimonian committed Sep 3, 2015
    Configuration menu
    Copy the full SHA
    d951c28 View commit details
    Browse the repository at this point in the history

  7. feat: Check that requested response types are allowed in settings

    @adalinesimonian
    adalinesimonian committed Sep 3, 2015
    Configuration menu
    Copy the full SHA
    a0a7350 View commit details
    Browse the repository at this point in the history

  8. feat(verifyClient): Enforce response_types (#95)

    @adalinesimonian
    adalinesimonian committed Sep 3, 2015
    Configuration menu
    Copy the full SHA
    f4ebf52 View commit details
    Browse the repository at this point in the history

  9. fix(Client): Equate undefined NODE_ENV to development environment 

    Makes behaviour consistent with the rest of Anvil Connect, where the lack of a NODE_ENV environment variable value denotes that the server is in a development environment.
    @adalinesimonian
    adalinesimonian committed Sep 3, 2015
    Configuration menu
    Copy the full SHA
    76d0937 View commit details
    Browse the repository at this point in the history

  10. Merge branch 'vsimonian-fix-unverified-redirects' into vsimonian-enfo… 

    …rce-grant_types-response_types
    @adalinesimonian
    adalinesimonian committed Sep 3, 2015
    Configuration menu
    Copy the full SHA
    0271fe3 View commit details
    Browse the repository at this point in the history

  11. refactor: consolidate response_type verification logic

    @adalinesimonian
    adalinesimonian committed Sep 3, 2015
    Configuration menu
    Copy the full SHA
    8dc37bc View commit details
    Browse the repository at this point in the history