forked from godotengine/godot
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
GDScript: fix regression when checking for virtual function implement…
…ation. Unfortunately it appears the virtual function checks in godotengine#77324 are not trustworthy at runtime, because objects can have scripts attached, but this information is not always available at compile-time. These checks need to be removed. The rest of the PR is still useful, making all method flags available to the analyzer, so a full revert isn't necessary/desirable. This reopens godotengine#76938, which will need another solution.
- Loading branch information
Showing
9 changed files
with
0 additions
and
44 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 0 additions & 2 deletions
2
modules/gdscript/tests/scripts/analyzer/errors/virtual_method_not_implemented.gd
This file was deleted.
Oops, something went wrong.
2 changes: 0 additions & 2 deletions
2
modules/gdscript/tests/scripts/analyzer/errors/virtual_method_not_implemented.out
This file was deleted.
Oops, something went wrong.
5 changes: 0 additions & 5 deletions
5
modules/gdscript/tests/scripts/analyzer/errors/virtual_super_not_implemented.gd
This file was deleted.
Oops, something went wrong.
2 changes: 0 additions & 2 deletions
2
modules/gdscript/tests/scripts/analyzer/errors/virtual_super_not_implemented.out
This file was deleted.
Oops, something went wrong.
11 changes: 0 additions & 11 deletions
11
modules/gdscript/tests/scripts/analyzer/features/virtual_method_implemented.gd
This file was deleted.
Oops, something went wrong.
1 change: 0 additions & 1 deletion
1
modules/gdscript/tests/scripts/analyzer/features/virtual_method_implemented.out
This file was deleted.
Oops, something went wrong.
10 changes: 0 additions & 10 deletions
10
modules/gdscript/tests/scripts/analyzer/features/virtual_super_implemented.gd
This file was deleted.
Oops, something went wrong.
1 change: 0 additions & 1 deletion
1
modules/gdscript/tests/scripts/analyzer/features/virtual_super_implemented.out
This file was deleted.
Oops, something went wrong.