Target node 8; remove regeneratorRuntime dependency #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ralbayaty
approved these changes
Feb 11, 2020
| "@babel/preset-env", | ||
| { | ||
| "targets": { | ||
| "node": "8.11" |
There was a problem hiding this comment.
would we want to do > 8.11 as well?
There was a problem hiding this comment.
Yeah, that is what this should mean, basically they all are supersets of the earliest one. I tested this on 8.11, 10.19, and 12.13
|
FWIW, I don't think we should be supporting node versions less than what we use in our stack anyways. |
Def, node 6 is EOL anyway: https://aws.amazon.com/blogs/developer/node-js-6-is-approaching-end-of-life-upgrade-your-aws-lambda-functions-to-the-node-js-10-lts/ |
|
@ralbayaty When you get around to merging #9 feel free to incorporate this one as well |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes babel target node 8. Node 8 has async / await support enabled by default and does not need babel's polyfill / regeneratorRuntime.
This will likely not work with node < 8. Versions < 8 seem to have a small percentage of usage
Type of change
Related issues
Closes #4