Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return all errors that come from the server #3

Merged
merged 1 commit into from
Feb 4, 2020
Merged

Return all errors that come from the server #3

merged 1 commit into from
Feb 4, 2020

Conversation

benogle
Copy link
Contributor

@benogle benogle commented Feb 4, 2020

Some errors were not being surfaced. This PR will surface them all

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@benogle benogle added the bug Something isn't working label Feb 4, 2020
@benogle benogle requested a review from ralbayaty February 4, 2020 19:14
ralbayaty
ralbayaty approved these changes Feb 4, 2020
View reviewed changes
Copy link
Contributor

@ralbayaty ralbayaty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

show me what you got errors

@benogle benogle merged commit 1cc1db6 into master Feb 4, 2020
@benogle benogle deleted the bo-improve-errors branch February 4, 2020 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ralbayaty ralbayaty ralbayaty approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benogle @ralbayaty