Add support for GraphQL API, starting with createEtchPacket #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newhouse
changed the title
newhouse
commented
Aug 20, 2020
| @@ -49,7 +49,10 @@ | |||
| "yargs": "^15.1.0" | |||
| }, | |||
| "dependencies": { | |||
| "extract-files": "^6", | |||
There was a problem hiding this comment.
This module is currently on v9.0.0 but have to drop to 6.0.0 to get it to work on Node 8
… body parsing helper. tidied up a lot
newhouse
force-pushed
the
newhouse/createEtchPacket
branch
from
f328520 to
3b567a9
Compare
benogle
reviewed
Aug 27, 2020
src/index.js
Outdated
Comment on lines
121
to
122
| // QUESTION: maybe we want to keeep responseQuery to ourselves while we figure out how we want it to | ||
| // feel to the Users? |
There was a problem hiding this comment.
I like the idea of having a default response, then letting them override it
| return path.basename(thing.client._httpMessage.path || '') | ||
| } | ||
|
|
||
| throw new Error('Unable to determine file name for this upload. Please pass it via options.filename.') |
| Mime.lookup(options.filepath || options.filename) | ||
| } | ||
|
|
||
| throw new Error('Unable to determine mime type for this upload. Please pass it via options.mimetype.') |
newhouse
commented
Aug 27, 2020
newhouse
changed the title
10 tasks
benogle
approved these changes
Sep 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
In concert with the big changes to the
createEtchPacketmutation, we'll want to add robust support for that mutation in this, our Node API client. This client previously did not have any support for GraphQL whatsoever, so it had to also be added in this PR.Here are the big things going on:
graphql-upload-compliant structures, allowing for files to be uploaded in a GraphQL mutationType of change
Related issues
Checklists
Development
Code review