Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: add warning about top languages card behavior. #2789

Merged

Conversation

qwerty541
Copy link
Collaborator

No description provided.

@vercel
Copy link

vercel bot commented Jun 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
github-readme-stats ✅ Ready (Inspect) Visit Preview Jun 9, 2023 1:41am

@qwerty541 qwerty541 requested a review from rickstaa June 8, 2023 06:17
@github-actions github-actions bot added the documentation Improvements or additions to documentation. label Jun 8, 2023
@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (38c8a7a) 97.59% compared to head (99f0c83) 97.59%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2789   +/-   ##
=======================================
  Coverage   97.59%   97.59%           
=======================================
  Files          24       24           
  Lines        4814     4814           
  Branches      447      447           
=======================================
  Hits         4698     4698           
  Misses        115      115           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

readme.md Outdated
@@ -357,6 +357,9 @@ The top languages card shows a GitHub user's most frequently used top language.
> **Note**
> Top Languages does not indicate the user's skill level or anything like that; it's a GitHub metric to determine which languages have the most code on GitHub. It is a new feature of github-readme-stats.

> **Warning**
> This card shows languages usage only inside your own non-forked repositories, not depending from who is the author of the commits. It does not include your contributions into another users/organizations repositories. If you have a technical solution how to improve this behavior share it with us by opening issue or discussion.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sadly, last time I checked, adding the forks will make the language results even worse. The only solution is to parse all the users' commits, which is not possible with the current GraphQL and time limits. I created https://github.com/orgs/community/discussions/18230 as a feature request for GitHub to solve this.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I therefore do not know if we should invite people to propose solutions. We can, however, state that due to current GraphQL and timeout limits, including forks or organization repositories is not feasible and that if people want this implemented they should show their support in https://github.com/orgs/community/discussions/18230? Something along that line?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't knew about this feature request. You are right, it is better to invite people to show support in this discussion. I have updated the code, please take a look.

@rickstaa rickstaa merged commit 7a302f6 into master Jun 9, 2023
@rickstaa rickstaa deleted the add_warning_into_readme_about_languages_card_behavior branch June 9, 2023 05:43
j4ckofalltrades pushed a commit to j4ckofalltrades/gh-stats that referenced this pull request Jun 10, 2023
* feat: add CACHE_SECONDS environment variable (anuraghazra#2266)

* feat: add CACHE_SECONDS environment variable

This commit adds the CACHE_SECONDS environment variable. This variable
can be used to circumvent our cache clamping values for self hosted
Vercel instances.

* refactor: apply formatter

* Remove redundant ask for theme screenshot from CONTRIBUTING.md (anuraghazra#2797)

* Fix clampValue function docstring (anuraghazra#2796)

* Docs: add warning about top languages card behavior. (anuraghazra#2789)

* Docs: add warning about top languages card behavior.

* dev

* dev

* Update readme.md about maxDuration (anuraghazra#2792)

* Update readme.md about maxDuration

I think we can remove this warning section since that value in  `.json` has been changed to 10 by default nowadays?

* Update readme.md

remove related section in self deployment section as well

* docs: add inverse maxDuration warning

---------

Co-authored-by: rickstaa <rick.staa@outlook.com>

* docs: add package debug steps to contribution guidelines (anuraghazra#2798)

* Beautify themes contribution note inside CONTRIBUTING.md (anuraghazra#2800)

---------

Co-authored-by: Rick Staa <rick.staa@outlook.com>
Co-authored-by: Alexandr Garbuzov <qwerty541zxc@gmail.com>
Co-authored-by: しぐれ <23041178+ForsakenRei@users.noreply.github.com>
devantler pushed a commit to devantler/github-readme-stats that referenced this pull request Sep 24, 2023
* Docs: add warning about top languages card behavior.

* dev

* dev
setdebarr pushed a commit to setdebarr/github-readme-stats that referenced this pull request Jan 12, 2024
* Docs: add warning about top languages card behavior.

* dev

* dev
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants