Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customization of ownerAffiliations with parameter #1122

Draft
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

developStorm
Copy link

@developStorm developStorm commented Jun 7, 2021

@vercel
Copy link

vercel bot commented Jun 7, 2021

@developStorm is attempting to deploy a commit to the github readme stats Team on Vercel.

A member of the Team first needs to authorize it.

@rickstaa
Copy link
Collaborator

rickstaa commented Jun 18, 2021

@developStorm Thanks a lot for this pull request it works perfectly on my fork.

@tyt2y3
Copy link

tyt2y3 commented Sep 14, 2021

Thank you so much! I find this useful 😀
I look forward to this being merged.

@rickstaa
Copy link
Collaborator

What is blocking this from being merged?

@rickstaa
Copy link
Collaborator

rickstaa commented Nov 9, 2021

@developStorm I reviewed your pull request and it looks good to me. I however noticed that the tests were broken. I created a pull request to fix this on your branch developStorm#1.

@anuraghazra Sorry for the PR waterfall. I, however, found too many changes for me to use the review suggestion tag.

Copy link
Collaborator

@rickstaa rickstaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this solution is more in line with #1 (comment).

src/fetchers/stats-fetcher.js Outdated Show resolved Hide resolved
src/fetchers/top-languages-fetcher.js Outdated Show resolved Hide resolved
@rickstaa
Copy link
Collaborator

rickstaa commented Nov 9, 2021

Apart from these changes, I think the new argument should be added to the documentation before this pull request can be merged.

@github-actions github-actions bot added card-i18n Card text translations. doc-translation README doc translations. themes Feature, Enhancement, Fixes related to themes. labels Dec 4, 2021
@anuraghazra
Copy link
Owner

Automated Theme Preview

title_color: #b57614 | icon_color: #af3a03 | text_color: #427b58 | bg_color: #fbf1c7

Preview Link

Hi, thanks for the theme contribution, please read our theme contribution guidelines.

We are currently only accepting color combinations from any VSCode theme or themes which have good color combination to minimize bloating the themes collection.

Also note that if this theme is exclusively for your personal use, then instead of adding it to our theme collection you can use card customization options

vercel.json Show resolved Hide resolved
@rickstaa

This comment has been minimized.

@rickstaa
Copy link
Collaborator

rickstaa commented Dec 4, 2021

Great, everything seems to work now. Thanks!

Rick Staa's Github stats

rickstaa pushed a commit to rickstaa/github-readme-stats that referenced this pull request Feb 22, 2022
rickstaa pushed a commit to rickstaa/github-readme-stats that referenced this pull request Mar 22, 2022
@github-actions github-actions bot removed the card-i18n Card text translations. label Oct 10, 2022
@codecov
Copy link

codecov bot commented Oct 10, 2022

Codecov Report

Attention: Patch coverage is 93.15068% with 5 lines in your changes missing coverage. Please review.

Project coverage is 96.84%. Comparing base (4b17300) to head (7337505).
Report is 675 commits behind head on master.

Files with missing lines Patch % Lines
src/common/utils.js 86.84% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1122      +/-   ##
==========================================
- Coverage   96.90%   96.84%   -0.07%     
==========================================
  Files          22       22              
  Lines        3882     3956      +74     
  Branches      337      341       +4     
==========================================
+ Hits         3762     3831      +69     
- Misses        118      123       +5     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rickstaa
Copy link
Collaborator

@developStorm I created #2277 as a replacement for #1122. Please take a look and close this PR if you think it suits your needs.

@rickstaa
Copy link
Collaborator

rickstaa commented Jan 24, 2023

@anuraghazra I'm okay with merging this since it is what the community wants. As far as I know, it will not deplete our PATs since it uses the same number of GraphQL points as the master branch. It will, however, not give accurate stats results on the Public instance unless FETCH_MULTI_PAGE_STARS is enabled. It also will make the language results more incorrect since we currently get the language results from the repository object (see #1122 (comment)). Maybe let's release this feature under the INCLUDE_ORGS environment variable? We can also remove the option entirely in the language card if you don't like the inaccuracies. With any option we still need to add:

  • Tests for the new role variable.
  • Merge fix: Fetch all repos for top languages #2111 under a MULTI_PAGE_LANGUAGES env variable so that it can be used in the GitHub action.
  • Maybe some documentation explaining the role variable and the language and stats card inaccuracies. We can add a section on experimental features in the readme.md.

@rickstaa
Copy link
Collaborator

Replaced by #2459 since I don't want to break @developStorm's master branch when I make a change.

@rickstaa rickstaa closed this Jan 24, 2023
@rickstaa rickstaa reopened this Jan 24, 2023
@rickstaa rickstaa closed this Jan 24, 2023
@rickstaa rickstaa reopened this Jan 24, 2023
@rickstaa rickstaa closed this Jan 24, 2023
@rickstaa rickstaa reopened this Jan 25, 2023
This commit fixes a small error in the stats-fetcher that caused the
`exclude_repo` parameter values to be seen as the `ownerAffiliation`
inputs.
@rickstaa rickstaa closed this Jan 25, 2023
kvdomingo pushed a commit to kvdomingo/github-readme-stats that referenced this pull request Mar 25, 2023
@rickstaa rickstaa reopened this Apr 28, 2023
@rickstaa rickstaa added the ⭐ top pull request Top pull request. label May 9, 2023
@rickstaa rickstaa mentioned this pull request Sep 3, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⭐ top pull request Top pull request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Add organization stats
6 participants