Fix the Ubuntu build on s390x #18
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* convert-rpm.sh uses hardcoded package versions, which can no longer
be found each time AlmaLinux is updated. Always fetch the current
versions.
* Fix ShellCheck warnings in this script.
* Don't silence wget output so that the script is debuggable.
* Remove the unnecessary "exit 0" at the end.
* Account for alien errors like the following:
Unpacking of 'dotnet-host-8.0.4-2.el9_4.s390x.rpm' failed at /usr/share/perl5/Alien/Package/Rpm.pm line 168.
and add a workaround from [1].
* Rebase runner-s390x.patch.
* Use SDK 8 on s390x, since that's what the latest runner requires.
* Move ARGS a bit lower in the Dockerfile to improve caching.
* Turn off package signature verification. AlmaLinux's .NET may contain
an outdated trust store. See [2] for details.
* Fix the packs symlinks.
* Pass /p:SelfContained=false to the test runner in order to avoid
apphost issues in ./dev.sh test.
[1] anup-kodlekere#14
[2] https://learn.microsoft.com/en-us/dotnet/core/tools/nuget-signed-package-verification
|
@anup-kodlekere @nealef Uli helped resolve the testing issue, and how things fully work for me. Could you take a look please? |
|
@nealef this seems to be in your territory, could you review this please? Also do you think this makes any of the previous PRs redundant? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I was asked if gaplib worked on s390x Ubuntu with the latest runner and realized that it's unfortunately quite broken at the moment. This PR summarizes my findings.
Uli gave me a hint on how to resolve the self-contained build issue for testing, so now everything fully works.
convert-rpm.sh uses hardcoded package versions, which can no longer
be found each time AlmaLinux is updated. Always fetch the current
versions.
Fix ShellCheck warnings in this script.
Don't silence wget output so that the script is debuggable.
Remove the unnecessary "exit 0" at the end.
Account for alien errors like the following:
Unpacking of 'dotnet-host-8.0.4-2.el9_4.s390x.rpm' failed at /usr/share/perl5/Alien/Package/Rpm.pm line 168.
and add a workaround from [1].
Rebase runner-s390x.patch.
Use SDK 8 on s390x, since that's what the latest runner requires.
Move ARGS a bit lower in the Dockerfile to improve caching.
Turn off package signature verification. AlmaLinux's .NET may contain
an outdated trust store. See [2] for details.
Fix the packs symlinks.
Pass /p:SelfContained=false to the test runner in order to avoid
apphost issues in ./dev.sh test.
[1] #14
[2] https://learn.microsoft.com/en-us/dotnet/core/tools/nuget-signed-package-verification