fix(liquid): add liquid percent.toFixed #5648
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ai-qing-hai
commented
Oct 17, 2023
•
ai-qing-hai
commented
lxfu1
reviewed
Oct 17, 2023
src/mark/liquid.ts
Outdated
| @@ -89,7 +89,7 @@ export const Liquid: CC<LiquidOptions> = (options) => { | |||
| }), | |||
| deepMix({}, DEFAULT_TEXT_OPTIONS, { | |||
| style: { | |||
| text: `${percent * 100} %`, | |||
| text: `${(percent * 100).toFixed(2)} %`, | |||
There was a problem hiding this comment.
感觉不能简单的toFixed， 例如 0.55 这种会被转换为 55.00%
There was a problem hiding this comment.
全局搜索 prettyNumber 这个函数，把它抽出来放在 src/utils/number.ts 里面，然后在这里使用：避免精度问题。
pearmini
requested changes
Oct 17, 2023
src/mark/liquid.ts
Outdated
| @@ -89,7 +89,7 @@ export const Liquid: CC<LiquidOptions> = (options) => { | |||
| }), | |||
| deepMix({}, DEFAULT_TEXT_OPTIONS, { | |||
| style: { | |||
| text: `${percent * 100} %`, | |||
| text: `${(percent * 100).toFixed(2)} %`, | |||
There was a problem hiding this comment.
全局搜索 prettyNumber 这个函数，把它抽出来放在 src/utils/number.ts 里面，然后在这里使用：避免精度问题。
pearmini
requested changes
Oct 17, 2023
src/mark/liquid.ts
Outdated
| @@ -89,7 +89,7 @@ export const Liquid: CC<LiquidOptions> = (options) => { | |||
| }), | |||
| deepMix({}, DEFAULT_TEXT_OPTIONS, { | |||
| style: { | |||
| text: `${percent * 100} %`, | |||
| text: `${(percent * 100).toFixed(2)} %`, | |||
|
这里 rebase 一下 v5，不要用 merge |
#5788 重新创建一个 pr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.