fix(legend): category do not update position (#5304)

antvis · Jul 12, 2023 · 95c9950 · 95c9950
1 parent 6ae86b7
commit 95c9950
Show file tree

Hide file tree

Showing 6 changed files with 9 additions and 2 deletions.
diff --git a/__tests__/integration/snapshots/api/chartChangeSize.png b/__tests__/integration/snapshots/api/chartChangeSize.png
diff --git a/.../integration/snapshots/interaction/countries-annotation-slider-filter/step0.png b/.../integration/snapshots/interaction/countries-annotation-slider-filter/step0.png
diff --git a/.../integration/snapshots/interaction/countries-annotation-slider-filter/step1.png b/.../integration/snapshots/interaction/countries-annotation-slider-filter/step1.png
diff --git a/__tests__/integration/snapshots/interaction/weather-line-legend-mark/step0.png b/__tests__/integration/snapshots/interaction/weather-line-legend-mark/step0.png
diff --git a/__tests__/plots/api/chart-change-size.ts b/__tests__/plots/api/chart-change-size.ts
@@ -11,7 +11,12 @@ export function chartChangeSize(context) {
   const div = document.createElement('div');
   container.appendChild(div);
 
-  const chart = new Chart({ theme: 'classic', container: div, canvas });
+  const chart = new Chart({
+    theme: 'classic',
+    container: div,
+    canvas,
+    padding: 'auto',
+  });
 
   chart.data([
     { genre: 'Sports', sold: 275 },
@@ -28,7 +33,8 @@ export function chartChangeSize(context) {
     .encode('x', 'genre')
     .encode('y', 'sold')
     .encode('color', 'genre')
-    .axis({ x: { animate: false }, y: { animate: false } });
+    .axis({ x: { animate: false }, y: { animate: false } })
+    .legend('color', [{}, { position: 'right' }]);
 
   const finished = chart.render();
 

diff --git a/src/component/utils.ts b/src/component/utils.ts
@@ -97,6 +97,7 @@ export class G2Layout extends Layout {
 export class LegendCategoryLayout extends G2Layout {
   update(options: any) {
     const { subOptions } = options;
+    this.attr(options);
     this.child?.update(subOptions);
   }
 }