Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCD-69 move to prod #71

Merged
merged 85 commits into from
Mar 27, 2023
Merged

SCD-69 move to prod #71

merged 85 commits into from
Mar 27, 2023

Conversation

sleepy0owl
Copy link
Member

@sleepy0owl sleepy0owl commented Mar 27, 2023

👮 Pull Request Checklist

📝 Description

  • This PR contains the code to create a PR checklist that will help the team in identifying a few common points that needs to be checked while raising a PR.

🎫 Associated JIRA tickets

  • SCD-18
    • A screenshot followed by the description of the ticket. This ticket deals with creating a common PR checklist template which will be improved continuously to help the developer.
    • Any additional information for testing the ticket.

⚔️ Mandatory Checks

  • Is the functionality working as expected?
  • Are the comments are clear and useful, and mostly explain why instead of what?
  • Does it match the required coding standards?
  • Is the performance up to the mark?

🛠️ Regular Checks

  • Spell Checks.

🗡️ Optional Checks

  • Schema Changes

🤳 PR Self-Review

  • DRY: Don't repeat yourself
  • YAGNI: You aren't gonna need it. Make sure you're not over-complicating something just to try & make it more future-proof 🙅‍♂️
    • P.S. According to Fowler, "Yagni only applies to capabilities built into the software to support a presumptive feature, it does not apply to effort to make the software easier to modify."
  • A link to some of the best practices for creating a PR

⚠️ Wait for PR status checks to complete before approving PR

ropoojary18 and others added 30 commits March 21, 2023 07:42
Generated by SqlDBM: Conference Data by "sourav.mondal@antstack.io"
added comment to test quality gate
sleepy0owl and others added 26 commits March 27, 2023 15:45
Generated by SqlDBM: Conference-data-snowflake by "sourav.mondal@antstack.io"
Generated by SqlDBM: Conference-data-snowflake by "sourav.mondal@antstack.io"
SCD-36 snowflake integration for refined layer (DEV)
SCD-4 Add update refined layer tables
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

14.8% 14.8% Coverage
0.0% 0.0% Duplication

@sleepy0owl sleepy0owl changed the title SCD_69 move to prod SCD-69 move to prod Mar 27, 2023
@sleepy0owl sleepy0owl requested a review from KrishnaMuddi March 27, 2023 13:37
@sleepy0owl sleepy0owl merged commit 983c9e9 into master Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants