Upgrade ClickHouse server image to v23.4 #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #306 +/- ##
==========================================
+ Coverage 66.56% 66.69% +0.12%
==========================================
Files 38 38
Lines 4783 4783
==========================================
+ Hits 3184 3190 +6
+ Misses 1452 1444 -8
- Partials 147 149 +2
*This pull request uses carry forward flags. Click here to find out more.
|
heanlan
force-pushed
the
upgrade-clickhouse
branch
5 times, most recently
from
74958b4 to
40b2873
Compare
yuntanghsu
reviewed
May 30, 2023
yanjunz97
reviewed
May 31, 2023
heanlan
force-pushed
the
upgrade-clickhouse
branch
from
9d5a1e3 to
9a53a17
Compare
heanlan
force-pushed
the
upgrade-clickhouse
branch
2 times, most recently
from
bc275de to
b85b98d
Compare
yanjunz97
reviewed
Jun 5, 2023
heanlan
force-pushed
the
upgrade-clickhouse
branch
from
13c3e37 to
abb8346
Compare
heanlan
force-pushed
the
upgrade-clickhouse
branch
from
abb8346 to
2b6e4b4
Compare
|
/theia-test-e2e |
dreamtalen
approved these changes
Jun 6, 2023
|
Let's don't merge this PR for now as we are still trying to figure out the e2e flakiness in |
- Upgrade ClickHouse server to v23.4 - Upgrade ClickHouse operator and metrics exporter to v0.21.0 Notable changes: - The inner table name of Materialized View has been changed to `.inner_id.<uuid>`. We are no longer able to find the table by self-defined Materialized View name. Thus, in `create_table.sh`, we save the data of Materialized Views to pre-defined underlying tables. - ClickHouse upgrade test used to always apply the latest clickhouse-operator-install-bundle.yaml. In this upgrade, latest operator yaml does not work with version N-1 ClickHouse data schema. Therefore, we change the test to use the correct version of operator yaml corresponding to the tested ClickHouse data schema. - We removed the theia- prefix in clickhouse operator images in - We increase theia-manager ping timeout when connecting to ClickHouse Service to fix test flakiness. Signed-off-by: heanlan <hanlan@vmware.com>
heanlan
force-pushed
the
upgrade-clickhouse
branch
from
2b6e4b4 to
99e8b52
Compare
Signed-off-by: heanlan <hanlan@vmware.com>
|
Please help review if the latest commit looks good to you Background: We found flakiness in I added a debug log in ClickHouse client code and extend the ping time out from 10s to 30s for better observation. Below is an example log file when the client trying to ping the DB: It turns out the testing iPerf traffic starts before the connection is ready. So we add a time wait as a workaround. Please check out the comment for details. |
yanjunz97
approved these changes
Jun 8, 2023
|
More info on FA Pod restart situation - we observe the Pod firstly in "Running" state, after some time it crashed and restarted. By checking the Pod log below, we found the error comes from timeout while pinging ClickHouse DB, and finally return to FA cmd/main.go |
yuntanghsu
approved these changes
Jun 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notable changes:
been changed to
.inner_id.<uuid>. We are no longer able tofind the table by self-defined Materialized View name. Thus,
in
create_table.sh, we save the data of Materialized Viewsto pre-defined underlying tables.
clickhouse-operator-install-bundle.yaml. In this upgrade,
latest operator yaml does not work with version N-1 ClickHouse
data schema. Therefore, we change the test to use the correct
version of operator yaml corresponding to the tested ClickHouse
data schema.
ClickHouse Service to fix test flakiness.
avoid missing the first a few records.
Signed-off-by: heanlan hanlan@vmware.com