Adapt CLI to use Theia Manager #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuntanghsu
force-pushed
the
add_cli_change
branch
3 times, most recently
from
153764b to
7a20b8c
Compare
yuntanghsu
force-pushed
the
add_cli_change
branch
from
7a20b8c to
930c0c9
Compare
yanjunz97
reviewed
Sep 28, 2022
yuntanghsu
force-pushed
the
add_cli_change
branch
3 times, most recently
from
0d26e88 to
7c8db42
Compare
Codecov Report
@@ Coverage Diff @@
## main #115 +/- ##
===========================================
+ Coverage 30.65% 51.76% +21.11%
===========================================
Files 11 11
Lines 1442 1161 -281
===========================================
+ Hits 442 601 +159
+ Misses 978 482 -496
- Partials 22 78 +56
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
yanjunz97
reviewed
Sep 30, 2022
yuntanghsu
force-pushed
the
add_cli_change
branch
4 times, most recently
from
728b431 to
b7ac23b
Compare
dreamtalen
reviewed
Oct 5, 2022
yuntanghsu
force-pushed
the
add_cli_change
branch
from
b7ac23b to
b2b9648
Compare
wsquan171
reviewed
Oct 7, 2022
| Host: host, | ||
| BearerToken: token, | ||
| TLSClientConfig: restclient.TLSClientConfig{ | ||
| Insecure: false, |
There was a problem hiding this comment.
do we want to expose Insecure as cli arg to be fail-safe?
There was a problem hiding this comment.
Maybe not? If we need Insecure=true, does it mean we have a wrong ca-crt? Or maybe we have some issues in Theia-manager? For both cases, do we still want to connect to Theia-manager?
yuntanghsu
force-pushed
the
add_cli_change
branch
6 times, most recently
from
e4db1fd to
0b4f6a8
Compare
|
/theia-test-e2e |
yuntanghsu
force-pushed
the
add_cli_change
branch
from
0b4f6a8 to
a7915b8
Compare
|
/theia-test-e2e |
yuntanghsu
force-pushed
the
add_cli_change
branch
4 times, most recently
from
8536ed3 to
43b1019
Compare
|
/theia-test-e2e |
1.Create a theia client with the ca.cert and token. 2.Use port-forwarder to connect to Theia Manager when running theia out of the cluster. 3.Add unit test. Signed-off-by: Yun-Tang Hsu <hsuy@vmware.com>
yuntanghsu
force-pushed
the
add_cli_change
branch
from
43b1019 to
3a114eb
Compare
|
/theia-test-e2e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the adaption of CLI in order to use Theia Manager, which includes:
Reviewers can focus on the changes under folder pkg/theia/commands.