Improvement for throughput related panels in Grafana #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuntanghsu
force-pushed
the
grafana_throughput
branch
3 times, most recently
from
618f43d to
9ac5502
Compare
|
/theia-test-e2e |
yuntanghsu
force-pushed
the
grafana_throughput
branch
from
9ac5502 to
6042caa
Compare
|
/theia-test-e2e |
|
/theia-test-e2e |
yuntanghsu
force-pushed
the
grafana_throughput
branch
from
6042caa to
dedd05f
Compare
|
/theia-test-e2e |
heanlan
reviewed
Sep 12, 2022
build/charts/theia/provisioning/dashboards/node_to_node_dashboard.json
Outdated
Show resolved
Hide resolved
…tions' throughput Signed-off-by: Yun-Tang Hsu <hsuy@vmware.com>
yuntanghsu
force-pushed
the
grafana_throughput
branch
from
dedd05f to
307f8b4
Compare
|
/theia-test-e2e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the throughput calculation for the panels aggregating connections' throughput.
Some panels use sum(throughput) when grouping the connections. The throughput it shows is not quite correct. For some short connections, they will occupy a large of proportion when we do the calculation.
Change it to SUM(octetDeltaCount)*8000/$__interval_ms to have accurate result.
Affected panel:
Signed-off-by: Yun-Tang Hsu hsuy@vmware.com