Fetch cloud credential secrets from all namespaces #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move RBAC of secret from role to cluster role to allow CPA controller to watch cloud credentials secrets from any namespace. If POD_NAMESPACE env is not set, secret watcher will watch for secrets in all namespace and if its set, it will watch only in that namespace. Signed-off-by: Rahul Jain <rahulj@vmware.com>
|
/nephe-test-e2e-agentless |
shenmo3
approved these changes
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow secret watcher to watch for cloud credential secrets from all namespace.
Changes
Move RBAC of secret from role to cluster role to allow CPA controller to watch cloud credentials secrets from any namespace. If POD_NAMESPACE env is not set, secret watcher will watch for secrets in all namespace and if its set, it will watch only in that namespace.