Move Plugin level lock to Account level #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/network/armnetwork" | ||
| "github.com/Azure/go-autorest/autorest/to" | ||
| "k8s.io/apimachinery/pkg/types" | ||
| "strings" |
There was a problem hiding this comment.
could you sort imports here?
Signed-off-by: Rahul Jain <rahulj@vmware.com>
|
/nephe-test-e2e-agentless |
1 similar comment
|
/nephe-test-e2e-agentless |
|
/nephe-test-e2e-azure |
3 similar comments
|
/nephe-test-e2e-azure |
|
/nephe-test-e2e-azure |
|
/nephe-test-e2e-azure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We had mutex lock at the plugin level, due to which any cloud operation for account1 was impacting account2.
Changes
Move plugin level lock to account level so that multiple cloud operation can happen in parallel. There is further room for optimization to identify what cloud calls can happen in parallel within an account rather than locking at account level.