fix reconciliation issue when ag is modified during controller restart #247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| err = computeService.removeReferencesToSecurityGroup(&securityGroupIdentifier.CloudResourceID, rgName, location, membershipOnly) | ||
| if err != nil { | ||
| return err | ||
| // remove attached rules for appliedTo sg but not address sg. this behavior is consistent with AWS. |
shenmo3
force-pushed
the
fix-reconciliation
branch
2 times, most recently
from
82c5067 to
c1d82a7
Compare
shenmo3
commented
Jun 14, 2023
Signed-off-by: Alexander Liu <alliu@vmware.com>
reachjainrahul
force-pushed
the
fix-reconciliation
branch
from
c1d82a7 to
6e3de0f
Compare
|
/nephe-test-e2e-kind |
1 similar comment
|
/nephe-test-e2e-kind |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, if the address group of network policies is modified during controller restart, the reconciliation process will encounter issues. The syncFromCloud will delete the previous address group before deleting the previous rules that still reference it. This lead to dependency violation in AWS and ASG not found error during rule updates in Azure. This PR addresses the problem by first updating address group references for appliedTo groups before deleting address groups.
Changes