Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add validations for NodeNetworkPolicy #6613

Merged
merged 1 commit into from
Aug 21, 2024
Merged

Add validations for NodeNetworkPolicy #6613

merged 1 commit into from
Aug 21, 2024

Conversation

Atish-iaf
Copy link
Contributor

Prevent ACNP appliedTo Node (NodeNetworkPolicy) with "enableLogging: true".
Prevent ACNP appliedTo Node (NodeNetworkPolicy) with other selectors.

For #6525

@Atish-iaf Atish-iaf added the kind/bug Categorizes issue or PR as related to a bug. label Aug 19, 2024
@Atish-iaf Atish-iaf requested a review from tnqn August 19, 2024 14:25
tnqn
tnqn previously approved these changes Aug 19, 2024
View reviewed changes
Copy link
Member

@tnqn tnqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hongliangl could you also take a look?

@rajnkamr rajnkamr added this to the Antrea v2.2 release milestone Aug 20, 2024
@rajnkamr rajnkamr added action/release-note Indicates a PR that should be included in release notes. area/network-policy Issues or PRs related to network policies. labels Aug 20, 2024
hongliangl
hongliangl reviewed Aug 21, 2024
View reviewed changes
Copy link
Contributor

@hongliangl hongliangl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall

docs/antrea-node-network-policy.md Outdated Show resolved Hide resolved
@Atish-iaf
Add validations for NodeNetworkPolicy
4f9cbfd 
Prevent ACNP appliedTo Node (NodeNetworkPolicy) with "enableLogging: true".
Prevent ACNP appliedTo Node (NodeNetworkPolicy) with other selectors.

For antrea-io#6525

Signed-off-by: Kumar Atish <kumar.atish@broadcom.com>
@Atish-iaf Atish-iaf requested a review from tnqn August 21, 2024 09:35
hongliangl
hongliangl approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@hongliangl hongliangl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tnqn
tnqn approved these changes Aug 21, 2024
View reviewed changes
Copy link
Member

@tnqn tnqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tnqn
Copy link
Member

tnqn commented Aug 21, 2024

/skip-all

1 similar comment
@tnqn
Copy link
Member

tnqn commented Aug 21, 2024

/skip-all

@tnqn tnqn merged commit 27ed93d into antrea-io:main Aug 21, 2024
54 of 58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajnkamr rajnkamr rajnkamr left review comments

@hongliangl hongliangl hongliangl approved these changes

@tnqn tnqn tnqn approved these changes

Assignees
No one assigned
Labels
action/release-note Indicates a PR that should be included in release notes. area/network-policy Issues or PRs related to network policies. kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
Antrea v2.2 release
Development

Successfully merging this pull request may close these issues.
4 participants
@Atish-iaf @tnqn @rajnkamr @hongliangl