antctl: fix cluster checker image #6565
Conversation
tnqn
added
area/component/antctl
| @@ -46,17 +46,21 @@ func Command() *cobra.Command { | |||
| } | |||
| command.Flags().StringVarP(&o.antreaNamespace, "namespace", "n", o.antreaNamespace, "Configure Namespace in which Antrea is running") | |||
| command.Flags().StringVar(&o.runFilter, "run", o.runFilter, "Run only the tests that match the provided regex") | |||
| command.Flags().StringVar(&o.testImage, "test-image", o.testImage, "Container image override for the installation checker") | |||
There was a problem hiding this comment.
maybe this should be agnhost-image instead of test-image?
I find it less confusing this way as the tests clearly require that the /agnhost command be included in this image
There was a problem hiding this comment.
Do you suggest to rename the parameter for check cluster too? Currently it's also test-image, I'm not sure if antrea-agent-image is good.
There was a problem hiding this comment.
I do have a preference for antrea-agent-image, but for that case we use the image more out of convenience. We could come up with an alternative Ubuntu-based image that would work just as well (as long as bash and modprobe are included. So we can keep the more generic name of test-image for check cluster if you prefer.
There was a problem hiding this comment.
Do you think we could publish an unified test image for both commands? I think agnhost will not be suffice in the future when we support validating wireguard, multicast etc. Then we would need to rename the parameter or provide test specific image parameters.
There was a problem hiding this comment.
Yes we could publish a unified image. It would be good if we could use the toolbox image, assuming we don't grow the size too much.
There was a problem hiding this comment.
I guess I should split the patch into two: a one-line change for bugfix, another for unifying the image and providing a parameter to override the image.
The image tag missed "v" when built for a released antctl. Signed-off-by: Quan Tian <quan.tian@broadcom.com>
tnqn
force-pushed
the
fix-antctl-check-image
branch
from
d82d876 to
a4663e5
Compare
tnqn
changed the title
|
/skip-all |
1 similar comment
|
/skip-all |
The image tag missed "v" when built for a released antctl. Signed-off-by: Quan Tian <quan.tian@broadcom.com>
The image tag missed "v" when built for a released antctl.
The patch also makes test images configurable to support scenarios that hardcoded images are not accessible.
Fixes #6563