Promote feature gate EndpointSlice to GA #5393
Conversation
hongliangl
force-pushed
the
20230816-upgrade-proxy
branch
from
1915b18 to
9a931e2
Compare
hongliangl
force-pushed
the
20230816-upgrade-proxy
branch
from
9a931e2 to
ff55c7d
Compare
There was a problem hiding this comment.
Please update the EndpointSlice and TopologyAwareHints section for the change.
I suppose - EndpointSlice is enabled can be removed for TopologyAwareHints?
There was a problem hiding this comment.
Not addressed? I think we can update the line EndpointSlice is enabled. as below?
EndpointSlice API version v1 is supported and set as enabled in Kubernetes
|
@hongliangl please resolve code conflicts. |
hongliangl
force-pushed
the
20230816-upgrade-proxy
branch
2 times, most recently
from
0969ae5 to
e8453fe
Compare
docs/feature-gates.md
Outdated
| @@ -101,7 +101,7 @@ for more information about TopologyAwareHints. | |||
| #### Requirements for this Feature | |||
|
|
|||
| - `AntreaProxy` is enabled. | |||
| - `EndpointSlice` is enabled. | |||
| - EndpointSlice API version v1 is supported and set as enabled in Kubernetes. | |||
There was a problem hiding this comment.
| - EndpointSlice API version v1 is supported and set as enabled in Kubernetes. | |
| - EndpointSlice API version v1 is available in Kubernetes. |
pkg/features/antrea_features.go
Outdated
| @@ -155,7 +156,7 @@ var ( | |||
| AntreaPolicy: {Default: true, PreRelease: featuregate.Beta}, | |||
| AntreaProxy: {Default: true, PreRelease: featuregate.Beta}, | |||
| Egress: {Default: true, PreRelease: featuregate.Beta}, | |||
| EndpointSlice: {Default: true, PreRelease: featuregate.Beta}, | |||
| EndpointSlice: {Default: true, PreRelease: featuregate.GA, LockToDefault: true}, | |||
There was a problem hiding this comment.
I feel we can be more conservative and do not lock it to true since the code is able to handle Endpoint API anyway. This leaves a workaround when there is something wrong with EndpointSlice API.
It's necessary to lock a feature gate to true the code is changed to not support its false case, like no longer checking the feature gate when executing related code.
There was a problem hiding this comment.
If so, do we need to add an option to replace feature gate EndpointSlice?
Signed-off-by: Hongliang Liu <lhongliang@vmware.com>
hongliangl
force-pushed
the
20230816-upgrade-proxy
branch
from
e8453fe to
81e1944
Compare
|
/test-all |
|
/test-conformance |
No description provided.