Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sorting by created at and updated at not working properly #74

Conversation

joakimunge
Copy link
Contributor

@joakimunge joakimunge commented Mar 10, 2020

Hey! I just found this project and loved it and wanted to contribute. I noticed that sorting by created_at and updated_at was not working properly due to incorrectly named props.

Screencap of the bug:

Kapture 2020-03-10 at 12 43 53

This PR also adds a workspace setting to not formatOnSave as the formatter is not working nicely together with eslint specifically for this rule:

prettier/prettier#3161

Looking forward do contribute!


Thank you for your contribution to the massCode repo.
Before submitting this PR, please make sure:

  • Your code builds clean without any errors or warnings
  • Your commits follow the сonvention

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • [] Yes
  • No

The PR fulfills these requirements:

  • It's submitted to the master branch for v1.x
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@antonreshetov
Copy link
Owner

Thank you for the PR. But let's stick to the rule, no side effects. Only bug - fix.

Editor settings are a personal user preference.

@joakimunge
Copy link
Contributor Author

@antonreshetov Sure thing. Maybe settings.json should be added to .gitignore in that case?

@antonreshetov antonreshetov merged commit 24602fa into antonreshetov:master Mar 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants