Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for tfupdate #328

Closed
jrottenberg opened this issue Jan 20, 2022 · 2 comments · Fixed by #342
Closed

Support for tfupdate #328

jrottenberg opened this issue Jan 20, 2022 · 2 comments · Fixed by #342
Assignees
@jrottenberg
Labels
estimate/2days Need 2 work days to be done feature New feature or request

Comments

@jrottenberg
Copy link
Contributor

Integrate tfupdate

Run https://github.com/minamijoyo/tfupdate/ on commit to pin the version of terraform and providers.

That will allow users to pin versions without efforts, at least for terraform itself and the providers.

How could pre-commit-terraform help solve your problem?

I have a simple PR : minamijoyo/tfupdate#63 but could rewrite it to be a bit more dynamic, ie detects the provider and update, overall it does the job.

If you are interested I can apply it to this repo.
@jrottenberg jrottenberg added the feature New feature or request label Jan 20, 2022
@MaxymVlasov
Copy link
Collaborator

Hi @jrottenberg
Yeah, it will be useful.

Check out https://github.com/antonbabenko/pre-commit-terraform/blob/master/.github/CONTRIBUTING.md as a start point and feel free to ask if you'll have any questions.

@MaxymVlasov MaxymVlasov added the estimate/2days Need 2 work days to be done label Feb 10, 2022
@jrottenberg jrottenberg mentioned this issue Feb 13, 2022
Merged
4 tasks
jrottenberg added a commit to jrottenberg/pre-commit-terraform that referenced this issue Feb 20, 2022
@jrottenberg
feat: tfupdate support
6379009 
Closes antonbabenko#328
jrottenberg added a commit to jrottenberg/pre-commit-terraform that referenced this issue Feb 20, 2022
@jrottenberg
feat: tfupdate
a806002 
Closes antonbabenko#328
jrottenberg added a commit to jrottenberg/pre-commit-terraform that referenced this issue Feb 20, 2022
@jrottenberg
feat: tfupdate
b4ee836 
Closes antonbabenko#328
jrottenberg added a commit to jrottenberg/pre-commit-terraform that referenced this issue Feb 20, 2022
@jrottenberg
feat: tfupdate
2c6c813 
Closes antonbabenko#328
jrottenberg added a commit to jrottenberg/pre-commit-terraform that referenced this issue Feb 20, 2022
@jrottenberg
feat: tfupdate integration (antonbabenko#328)
2dd8fcb 
Closes antonbabenko#328
jrottenberg added a commit to jrottenberg/pre-commit-terraform that referenced this issue Feb 28, 2022
@jrottenberg
feat: tfupdate integration (antonbabenko#328)
3cdd676
jrottenberg added a commit to jrottenberg/pre-commit-terraform that referenced this issue Feb 28, 2022
@jrottenberg
feat: tfupdate integration (antonbabenko#328)
a2d7be3
jrottenberg added a commit to jrottenberg/pre-commit-terraform that referenced this issue Feb 28, 2022
@jrottenberg
feat: tfupdate integration (antonbabenko#328)
ae086aa
jrottenberg added a commit to jrottenberg/pre-commit-terraform that referenced this issue Feb 28, 2022
@jrottenberg
feat: tfupdate integration (antonbabenko#328)
1d86be0
jrottenberg added a commit to jrottenberg/pre-commit-terraform that referenced this issue Feb 28, 2022
@jrottenberg
feat: tfupdate integration (antonbabenko#328)
32a400d
jrottenberg added a commit to jrottenberg/pre-commit-terraform that referenced this issue Feb 28, 2022
@jrottenberg
feat: tfupdate integration (antonbabenko#328)
38dc933
jrottenberg added a commit to jrottenberg/pre-commit-terraform that referenced this issue Mar 5, 2022
@jrottenberg @yermulnik
feat: tfupdate integration (antonbabenko#328)
1908e84 
Co-authored-by: yermulnik <yz@yz.kiev.ua>
jrottenberg added a commit to jrottenberg/pre-commit-terraform that referenced this issue Mar 6, 2022
@jrottenberg @yermulnik
feat: tfupdate integration (antonbabenko#328)
b7693e8 
Co-authored-by: yermulnik <yz@yz.kiev.ua>
@github-actions
Copy link

This issue has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this issue will be closed in 10 days

@github-actions github-actions bot added the stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 13, 2022
@MaxymVlasov MaxymVlasov removed the stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 15, 2022
jrottenberg added a commit to jrottenberg/pre-commit-terraform that referenced this issue Apr 13, 2022
@jrottenberg @yermulnik
feat: tfupdate integration (antonbabenko#328)
e702952 
Co-authored-by: yermulnik <yz@yz.kiev.ua>
jrottenberg added a commit to jrottenberg/pre-commit-terraform that referenced this issue Apr 13, 2022
@jrottenberg @yermulnik
feat: tfupdate integration (antonbabenko#328)
6e1635f 
Co-authored-by: yermulnik <yz@yz.kiev.ua>
MaxymVlasov pushed a commit to jrottenberg/pre-commit-terraform that referenced this issue Apr 13, 2022
@jrottenberg @yermulnik @MaxymVlasov
feat: tfupdate integration (antonbabenko#328)
579fdcb 
Co-authored-by: yermulnik <yz@yz.kiev.ua>
MaxymVlasov pushed a commit to jrottenberg/pre-commit-terraform that referenced this issue Apr 13, 2022
@jrottenberg @yermulnik @MaxymVlasov
feat: tfupdate integration (antonbabenko#328)
e2c10d8 
Co-authored-by: yermulnik <yz@yz.kiev.ua>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jrottenberg jrottenberg

Labels
estimate/2days Need 2 work days to be done feature New feature or request
Projects
None yet
Milestone
No milestone
2 participants
@jrottenberg @MaxymVlasov